From 137c1e736f4572198929ecd4f7e88a2586224650 Mon Sep 17 00:00:00 2001 From: Max Romanov Date: Thu, 23 Jul 2020 14:24:55 +0300 Subject: [PATCH] Fixing main and application port structs file descriptor init. Correct value for non-initialized file descriptor is -1, because most of the checks in libunit compares file descriptor with -1 before performing an action. Using 0 as default value, may cause to close file descriptor #0, this may affect application logic. It is not required to list this patch in changelog because impact is not seen by end users. --- src/nxt_application.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/nxt_application.c b/src/nxt_application.c index 834badf9..c331764f 100644 --- a/src/nxt_application.c +++ b/src/nxt_application.c @@ -1282,6 +1282,7 @@ nxt_unit_default_init(nxt_task_t *task, nxt_unit_init_t *init) init->ready_port.id.pid = main_port->pid; init->ready_port.id.id = main_port->id; + init->ready_port.in_fd = -1; init->ready_port.out_fd = main_port->pair[1]; nxt_fd_blocking(task, main_port->pair[1]); @@ -1291,6 +1292,7 @@ nxt_unit_default_init(nxt_task_t *task, nxt_unit_init_t *init) init->read_port.id.pid = my_port->pid; init->read_port.id.id = my_port->id; init->read_port.in_fd = my_port->pair[0]; + init->read_port.out_fd = -1; nxt_fd_blocking(task, my_port->pair[0]);