From 13a06497def68d8157dfe2b6e0a7f7edcc2ef477 Mon Sep 17 00:00:00 2001 From: Tiago Natel de Moura Date: Thu, 7 Jan 2021 16:51:27 +0000 Subject: [PATCH] Tests: reordered asserts to avoid a test race. The mount points are unmounted in the main process after it detects the app process died. By testing the `tmpfs: true` first, it happens that main could start the `tmpfs: false` test case before main cleans the old process mount points. --- test/test_go_isolation.py | 20 ++++++++++++-------- 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/test/test_go_isolation.py b/test/test_go_isolation.py index 48c1b80c..0cd83056 100644 --- a/test/test_go_isolation.py +++ b/test/test_go_isolation.py @@ -342,14 +342,6 @@ class TestGoIsolation(TestApplicationGo): 'pid': True } - self.load('ns_inspect', isolation=isolation) - - obj = self.getjson(url='/?mounts=true')['body'] - - assert ( - "/ /tmp" in obj['Mounts'] and "tmpfs" in obj['Mounts'] - ), 'app has /tmp mounted on /' - isolation['automount'] = { 'tmpfs': False } @@ -361,3 +353,15 @@ class TestGoIsolation(TestApplicationGo): assert ( "/ /tmp" not in obj['Mounts'] and "tmpfs" not in obj['Mounts'] ), 'app has no /tmp mounted' + + isolation['automount'] = { + 'tmpfs': True + } + + self.load('ns_inspect', isolation=isolation) + + obj = self.getjson(url='/?mounts=true')['body'] + + assert ( + "/ /tmp" in obj['Mounts'] and "tmpfs" in obj['Mounts'] + ), 'app has /tmp mounted on /'