technocloud-public/nginx-unit
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fixing leakage caused by incorrect in_hash flag cleanup.

Browse Source 
Large-bodied requests are added to the request hash to be found when the body
arrives.  However, changeset 1d84b9e4b459 introduced a bug: the 'in_hash' flag,
used to remove the request from the hash at request release, was cleared after
the first successful request lookup.  As a result, the entry was never removed.
This commit is contained in:
Max Romanov
2020-09-30 01:17:09 +03:00
parent 67d33fac66
commit 153e8a8779
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/nxt_unit.c
View File

@@ -6202,7 +6202,9 @@ nxt_unit_request_hash_find(nxt_unit_ctx_t *ctx, uint32_t stream, int remove)
case NXT_OK: case NXT_OK:
req_impl = nxt_container_of(lhq.value, nxt_unit_request_info_impl_t, req_impl = nxt_container_of(lhq.value, nxt_unit_request_info_impl_t,
req); req);
if (remove) {
req_impl->in_hash = 0; req_impl->in_hash = 0;
}
return lhq.value; return lhq.value;