technocloud-public/nginx-unit
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fixing a crash after applying the wrong TLS configuration.

Browse Source 
When an invalid TLS configuration is applied (such as the conf_commands
feature), nxt_cert_store_get() creates a buffer to send a certificate request
to the main process and adds its default completion handler to an asynchronous
queue to free the allocated buffer.  However, if configuration fails,
nxt_router_conf_error() removes the memory pool used to allocate the buffer,
causing a crash when the completion handler is dispatched.


Assertion "src/nxt_buf.c:208 assertion failed: data == b->parent" is triggered
when is NXT_DEBUG enabled in the configure script.


This patch uses a reference counter to retain the memory pool and redefines the
completion handler to free the buffer before releasing the memory pool.
This commit is contained in:
Andrey Suvorov
2021-05-17 14:28:38 -07:00
parent 1198118b3b
commit 19dfeba86b
2 changed files with 22 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/nxt_router.c
View File

@@ -773,7 +773,7 @@ fail:
msg->port_msg.stream, 0, NULL);
if (tmcf != NULL) {
nxt_mp_destroy(tmcf->mem_pool);
nxt_mp_release(tmcf->mem_pool);
}
cleanup:
@@ -1061,7 +1061,7 @@ nxt_router_conf_ready(nxt_task_t *task, nxt_router_temp_conf_t *tmcf)
nxt_mp_destroy(rtcf->mem_pool);
}
nxt_mp_destroy(tmcf->mem_pool);
nxt_mp_release(tmcf->mem_pool);
}
@@ -1120,7 +1120,7 @@ nxt_router_conf_error(nxt_task_t *task, nxt_router_temp_conf_t *tmcf)
nxt_router_conf_send(task, tmcf, NXT_PORT_MSG_RPC_ERROR);
nxt_mp_destroy(tmcf->mem_pool);
nxt_mp_release(tmcf->mem_pool);
}