technocloud-public/nginx-unit
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Remove a useless assignment in nxt_mem_zone_alloc_pages().

Browse Source 
This was reported by the 'Clang Static Analyzer' as a 'dead nested
assignment'.

We assign prev_size then check if it's != 0 and if true we then set
prev_pages to page_size right shifted by two at the same time setting
prev_size to be right shifted by two (>>=), however page_size is never
used again so no need to set it here.

Reviewed-by: Alejandro Colomar <alx@nginx.com>
Signed-off-by: Andrew Clayton <a.clayton@nginx.com>
This commit is contained in:
Andrew Clayton
2023-03-15 03:48:48 +00:00
parent 8a9e078e54
commit 4852057124
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/nxt_mem_zone.c
View File

@@ -672,7 +672,7 @@ nxt_mem_zone_alloc_pages(nxt_mem_zone_t *zone, size_t alignment, uint32_t pages)
prev_size = p - (u_char *) block; prev_size = p - (u_char *) block;
if (prev_size != 0) { if (prev_size != 0) {
prev_pages = prev_size >>= zone->page_size_shift; prev_pages = prev_size >> zone->page_size_shift;
node_pages -= prev_pages; node_pages -= prev_pages;
block->size = prev_pages; block->size = prev_pages;