technocloud-public/nginx-unit
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Removed implicit call of nxt_thread() in nxt_thread_tid().

Browse Source 
Explicit is better than implicit © The Zen of Python.

The nxt_thread_tid(NULL) call was used only twice in the code
and such behaviour was specific to nxt_thread_tid() function.
This commit is contained in:
Valentin Bartenev
2018-07-27 17:52:21 +03:00
parent 12c890c1ca
commit 4b67de4bbb
3 changed files with 2 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/nxt_mp.c
View File

@@ -233,7 +233,7 @@ nxt_mp_thread_adopt(nxt_mp_t *mp)
{ {
#if (NXT_DEBUG) #if (NXT_DEBUG)
mp->pid = nxt_pid; mp->pid = nxt_pid;
mp->tid = nxt_thread_tid(NULL); mp->tid = nxt_thread_tid(nxt_thread());
#endif #endif
} }

2
src/nxt_random.c
View File

@@ -99,7 +99,7 @@ nxt_random_stir(nxt_random_t *r)
key.value[0] ^= tv.tv_usec; key.value[0] ^= tv.tv_usec;
key.value[1] ^= tv.tv_sec; key.value[1] ^= tv.tv_sec;
key.value[2] ^= nxt_pid; key.value[2] ^= nxt_pid;
key.value[3] ^= (uintptr_t) nxt_thread_tid(NULL); key.value[3] ^= (uintptr_t) nxt_thread_tid(nxt_thread());
} }
nxt_random_add(r, key.bytes, NXT_RANDOM_KEY_SIZE); nxt_random_add(r, key.bytes, NXT_RANDOM_KEY_SIZE);

4
src/nxt_thread.c
View File

@@ -242,10 +242,6 @@ nxt_thread_wait(nxt_thread_handle_t handle)
nxt_tid_t nxt_tid_t
nxt_thread_tid(nxt_thread_t *thr) nxt_thread_tid(nxt_thread_t *thr)
{ {
if (thr == NULL) {
thr = nxt_thread();
}
#if (NXT_HAVE_THREAD_STORAGE_CLASS) #if (NXT_HAVE_THREAD_STORAGE_CLASS)
if (nxt_slow_path(thr->tid == 0)) { if (nxt_slow_path(thr->tid == 0)) {