Using malloc/free for the http fields hash.
This is required due to lack of a graceful shutdown: there is a small gap between the runtime's memory pool release and router process's exit. Thus, a worker thread may start processing a request between these two operations, which may result in an http fields hash access and subsequent crash. To simplify issue reproduction, it makes sense to add a 2 sec sleep before exit() in nxt_runtime_exit().
This commit is contained in:
@@ -186,16 +186,16 @@ static nxt_http_field_proc_t nxt_h1p_peer_fields[] = {
|
||||
|
||||
|
||||
nxt_int_t
|
||||
nxt_h1p_init(nxt_task_t *task, nxt_runtime_t *rt)
|
||||
nxt_h1p_init(nxt_task_t *task)
|
||||
{
|
||||
nxt_int_t ret;
|
||||
|
||||
ret = nxt_http_fields_hash(&nxt_h1p_fields_hash, rt->mem_pool,
|
||||
ret = nxt_http_fields_hash(&nxt_h1p_fields_hash,
|
||||
nxt_h1p_fields, nxt_nitems(nxt_h1p_fields));
|
||||
|
||||
if (nxt_fast_path(ret == NXT_OK)) {
|
||||
ret = nxt_http_fields_hash(&nxt_h1p_peer_fields_hash,
|
||||
rt->mem_pool, nxt_h1p_peer_fields,
|
||||
nxt_h1p_peer_fields,
|
||||
nxt_nitems(nxt_h1p_peer_fields));
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user