technocloud-public/nginx-unit
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Added error response logging.

Browse Source 
Every internal server error response should have a clear description in log.
This commit is contained in:
Max Romanov
2020-10-28 00:01:46 +03:00
parent 38a9027fe5
commit 735bb2f127
1 changed files with 10 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/nxt_router.c
View File

@@ -3722,6 +3722,7 @@ static void
nxt_router_response_ready_handler(nxt_task_t *task, nxt_port_recv_msg_t *msg, nxt_router_response_ready_handler(nxt_task_t *task, nxt_port_recv_msg_t *msg,
void *data) void *data)
{ {
size_t b_size, count;
nxt_int_t ret; nxt_int_t ret;
nxt_app_t *app; nxt_app_t *app;
nxt_buf_t *b, *next; nxt_buf_t *b, *next;
@@ -3787,15 +3788,20 @@ nxt_router_response_ready_handler(nxt_task_t *task, nxt_port_recv_msg_t *msg,
nxt_http_request_send_body(task, r, NULL); nxt_http_request_send_body(task, r, NULL);
} else { } else {
size_t b_size = nxt_buf_is_mem(b) ? nxt_buf_mem_used_size(&b->mem) : 0; b_size = nxt_buf_is_mem(b) ? nxt_buf_mem_used_size(&b->mem) : 0;
if (nxt_slow_path(b_size < sizeof(*resp))) { if (nxt_slow_path(b_size < sizeof(nxt_unit_response_t))) {
nxt_alert(task, "response buffer too small: %z", b_size);
goto fail; goto fail;
} }
resp = (void *) b->mem.pos; resp = (void *) b->mem.pos;
if (nxt_slow_path(b_size < sizeof(*resp) count = (b_size - sizeof(nxt_unit_response_t))
+ resp->fields_count * sizeof(nxt_unit_field_t))) { / sizeof(nxt_unit_field_t);
if (nxt_slow_path(count < resp->fields_count)) {
nxt_alert(task, "response buffer too small for fields count: %D",
resp->fields_count);
goto fail; goto fail;
} }