Tests: switched to using f-strings.
Previously, it was necessary to support older versions of Python for compatibility. F-strings were released in Python 3.6. Python 3.5 was marked as unsupported by the end of 2020, so now it's possible to start using f-strings safely for better readability and performance.
This commit is contained in:
@@ -10,16 +10,16 @@ class TestStaticVariables(TestApplicationProto):
|
||||
|
||||
@pytest.fixture(autouse=True)
|
||||
def setup_method_fixture(self, temp_dir):
|
||||
os.makedirs(temp_dir + '/assets/dir')
|
||||
os.makedirs(temp_dir + '/assets/d$r')
|
||||
Path(temp_dir + '/assets/index.html').write_text('0123456789')
|
||||
Path(temp_dir + '/assets/dir/file').write_text('file')
|
||||
Path(temp_dir + '/assets/d$r/file').write_text('d$r')
|
||||
os.makedirs(f'{temp_dir}/assets/dir')
|
||||
os.makedirs(f'{temp_dir}/assets/d$r')
|
||||
Path(f'{temp_dir}/assets/index.html').write_text('0123456789')
|
||||
Path(f'{temp_dir}/assets/dir/file').write_text('file')
|
||||
Path(f'{temp_dir}/assets/d$r/file').write_text('d$r')
|
||||
|
||||
self._load_conf(
|
||||
{
|
||||
"listeners": {"*:7080": {"pass": "routes"}},
|
||||
"routes": [{"action": {"share": temp_dir + "/assets$uri"}}],
|
||||
"routes": [{"action": {"share": f'{temp_dir}/assets$uri'}}],
|
||||
}
|
||||
)
|
||||
|
||||
@@ -27,37 +27,37 @@ class TestStaticVariables(TestApplicationProto):
|
||||
if isinstance(share, list):
|
||||
return self.conf(share, 'routes/0/action/share')
|
||||
|
||||
return self.conf('"' + share + '"', 'routes/0/action/share')
|
||||
return self.conf(f'"{share}"', 'routes/0/action/share')
|
||||
|
||||
def test_static_variables(self, temp_dir):
|
||||
assert self.get(url='/index.html')['status'] == 200
|
||||
assert self.get(url='/d$r/file')['status'] == 200
|
||||
|
||||
assert 'success' in self.update_share('$uri')
|
||||
assert self.get(url=temp_dir + '/assets/index.html')['status'] == 200
|
||||
assert self.get(url=f'{temp_dir}/assets/index.html')['status'] == 200
|
||||
|
||||
assert 'success' in self.update_share(temp_dir + '/assets${uri}')
|
||||
assert 'success' in self.update_share(f'{temp_dir}/assets${{uri}}')
|
||||
assert self.get(url='/index.html')['status'] == 200
|
||||
|
||||
def test_static_variables_array(self, temp_dir):
|
||||
assert 'success' in self.update_share(
|
||||
[temp_dir + '/assets$uri', '$uri']
|
||||
[f'{temp_dir}/assets$uri', '$uri']
|
||||
)
|
||||
|
||||
assert self.get(url='/dir/file')['status'] == 200
|
||||
assert self.get(url=temp_dir + '/assets/index.html')['status'] == 200
|
||||
assert self.get(url=f'{temp_dir}/assets/index.html')['status'] == 200
|
||||
assert self.get(url='/blah')['status'] == 404
|
||||
|
||||
assert 'success' in self.conf(
|
||||
{
|
||||
"share": [temp_dir + '/assets$uri', '$uri'],
|
||||
"share": [f'{temp_dir}/assets$uri', '$uri'],
|
||||
"fallback": {"return": 201},
|
||||
},
|
||||
'routes/0/action',
|
||||
)
|
||||
|
||||
assert self.get(url='/dir/file')['status'] == 200
|
||||
assert self.get(url=temp_dir + '/assets/index.html')['status'] == 200
|
||||
assert self.get(url=f'{temp_dir}/assets/index.html')['status'] == 200
|
||||
assert self.get(url='/dir/blah')['status'] == 201
|
||||
|
||||
def test_static_variables_buildin_start(self, temp_dir):
|
||||
@@ -65,15 +65,15 @@ class TestStaticVariables(TestApplicationProto):
|
||||
assert self.get(url=temp_dir)['status'] == 200
|
||||
|
||||
def test_static_variables_buildin_mid(self, temp_dir):
|
||||
assert 'success' in self.update_share(temp_dir + '$uri/index.html')
|
||||
assert 'success' in self.update_share(f'{temp_dir}$uri/index.html')
|
||||
assert self.get(url='/assets')['status'] == 200
|
||||
|
||||
def test_static_variables_buildin_end(self):
|
||||
assert self.get(url='/index.html')['status'] == 200
|
||||
|
||||
def test_static_variables_invalid(self, temp_dir):
|
||||
assert 'error' in self.update_share(temp_dir + '/assets/d$r$uri')
|
||||
assert 'error' in self.update_share(temp_dir + '/assets/$$uri')
|
||||
assert 'error' in self.update_share(f'{temp_dir}/assets/d$r$uri')
|
||||
assert 'error' in self.update_share(f'{temp_dir}/assets/$$uri')
|
||||
assert 'error' in self.update_share(
|
||||
[temp_dir + '/assets$uri', temp_dir + '/assets/dir', '$$uri']
|
||||
[f'{temp_dir}/assets$uri', f'{temp_dir}/assets/dir', '$$uri']
|
||||
)
|
||||
|
||||
Reference in New Issue
Block a user