technocloud-public/nginx-unit
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Router: more logical code order change.

Browse Source 
Updating the router engines list before posting jobs to worker thread
engines is more logical because worker threads may exit after the posting.
However, the previous code was safe because an engine is freed by
the router main thread after worker its thread has exited.
This commit is contained in:
Igor Sysoev
2017-09-15 12:27:24 +03:00
parent 309ba5abf2
commit 7c1db30994
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/nxt_router.c
View File

@@ -1548,8 +1548,6 @@ nxt_router_engines_post(nxt_router_t *router, nxt_router_temp_conf_t *tmcf)
for (n = tmcf->engines->nelts; n != 0; n--) { for (n = tmcf->engines->nelts; n != 0; n--) {
engine = recf->engine; engine = recf->engine;
nxt_router_engine_post(engine, recf->jobs);
switch (recf->action) { switch (recf->action) {
case NXT_ROUTER_ENGINE_KEEP: case NXT_ROUTER_ENGINE_KEEP:
@@ -1564,6 +1562,8 @@ nxt_router_engines_post(nxt_router_t *router, nxt_router_temp_conf_t *tmcf)
break; break;
} }
nxt_router_engine_post(engine, recf->jobs);
recf++; recf++;
} }
} }