technocloud-public/nginx-unit
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

HTTP parser: simplified nxt_http_parse_field_value().

Browse Source 
There's no need in loop after 4ac474b68658.

Found by Coverity (CID 259713).
This commit is contained in:
Valentin Bartenev
2018-01-25 10:31:22 +03:00
parent 4b19848e4e
commit 7fe8f72364
1 changed files with 11 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
src/nxt_http_parse.c
View File

@@ -629,27 +629,23 @@ nxt_http_parse_field_value(nxt_http_request_parse_t *rp, u_char **pos,
p += rp->field_value.length;
for ( ;; ) {
p = nxt_http_lookup_field_end(p, end);
p = nxt_http_lookup_field_end(p, end);
if (nxt_slow_path(p == end)) {
len = p - *pos;
if (nxt_slow_path(p == end)) {
len = p - *pos;
if (nxt_slow_path(len > NXT_HTTP_MAX_FIELD_VALUE)) {
return NXT_HTTP_PARSE_TOO_LARGE_FIELD;
}
rp->field_value.length = len;
rp->handler = &nxt_http_parse_field_value;
return NXT_AGAIN;
if (nxt_slow_path(len > NXT_HTTP_MAX_FIELD_VALUE)) {
return NXT_HTTP_PARSE_TOO_LARGE_FIELD;
}
ch = *p;
rp->field_value.length = len;
rp->handler = &nxt_http_parse_field_value;
return NXT_AGAIN;
}
if (nxt_fast_path(ch == '\r' || ch == '\n')) {
break;
}
ch = *p;
if (nxt_slow_path(ch != '\r' && ch != '\n')) {
return NXT_HTTP_PARSE_INVALID;
}