technocloud-public/nginx-unit
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Prevent a possible NULL de-reference in nxt_job_create().

Browse Source 
We allocate 'job' we then have a check if it's not NULL and do stuff
with it, but then we accessed it outside this check.

Simply return if job is NULL.

Reviewed-by: Alejandro Colomar <alx@nginx.com>
Signed-off-by: Andrew Clayton <a.clayton@nginx.com>
This commit is contained in:
Andrew Clayton
2023-03-14 17:31:48 +00:00
parent 22993fe41a
commit 8a9e078e54
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/nxt_job.c
View File

@@ -32,11 +32,13 @@ nxt_job_create(nxt_mp_t *mp, size_t size)
cache_size = size; cache_size = size;
} }
if (nxt_fast_path(job != NULL)) { if (nxt_slow_path(job == NULL)) {
return NULL;
}
job->cache_size = (uint16_t) cache_size; job->cache_size = (uint16_t) cache_size;
job->mem_pool = mp; job->mem_pool = mp;
nxt_job_set_name(job, "job"); nxt_job_set_name(job, "job");
}
/* Allow safe nxt_queue_remove() in nxt_job_destroy(). */ /* Allow safe nxt_queue_remove() in nxt_job_destroy(). */
nxt_queue_self(&job->link); nxt_queue_self(&job->link);