technocloud-public/nginx-unit
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fixed main() prototypes in auto tests.

Browse Source 
Future releases of GCC are planning to remove[0] default support for
some old features that were removed from C99 but GCC still accepts.

We can test for these changes by using the following -Werror=
directives

  -Werror=implicit-int
  -Werror=implicit-function-declaration
  -Werror=int-conversion
  -Werror=strict-prototypes
  -Werror=old-style-definition

Doing so revealed an issue with the auto/ tests in that the test
programs always define main as

  int main()

rather than

  int main(void)

which results in a bunch of errors like

build/autotest.c:3:23: error: function declaration isn't a prototype [-Werror=strict-prototypes]
    3 |                   int main() {
      |                       ^~~~
build/autotest.c: In function 'main':
build/autotest.c:3:23: error: old-style function definition [-Werror=old-style-definition]

The fix was easy, it only required fixing the main prototype with

  find -type f -exec sed -i 's/int main() {/int main(void) {/g' {} \;

Regardless of these upcoming GCC changes, this is probably a good thing
to do anyway for correctness.

[0]: https://fedoraproject.org/wiki/Changes/PortingToModernC

Link: <https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/message/CJXKTLXJUPZ4F2C2VQOTNMEA5JAUPMBD/>
Link: <https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/message/6SGHPHPAXKCVJ6PUZ57WVDQ5TDBVIRMF/>
Reviewed-by: Alejandro Colomar <alx@nginx.com>
Signed-off-by: Andrew Clayton <a.clayton@nginx.com>
This commit is contained in:
Andrew Clayton
2022-10-28 00:17:51 +01:00
parent a3cb07df20
commit 8f0dd9478e
22 changed files with 129 additions and 129 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
auto/clang
View File

@@ -14,7 +14,7 @@ nxt_feature_libs=
nxt_feature_test="#include <stdio.h>
#define set(dummy, ...) sprintf(__VA_ARGS__)
int main() {
int main(void) {
char buf[4];
buf[0] = '0';
@@ -37,7 +37,7 @@ if [ $nxt_found = no ]; then
nxt_feature_test="#include <stdio.h>
#define set(dummy, args...) sprintf(args)
int main() {
int main(void) {
char buf[4];
buf[0] = '0';
@@ -70,7 +70,7 @@ nxt_feature_name=NXT_HAVE_BUILTIN_UNREACHABLE
nxt_feature_run=no
nxt_feature_incs=
nxt_feature_libs=
nxt_feature_test="int main() {
nxt_feature_test="int main(void) {
__builtin_unreachable();
}"
. auto/feature
@@ -81,7 +81,7 @@ nxt_feature_name=NXT_HAVE_BUILTIN_PREFETCH
nxt_feature_run=no
nxt_feature_incs=
nxt_feature_libs=
nxt_feature_test="int main() {
nxt_feature_test="int main(void) {
__builtin_prefetch(0);
return 0;
}"
@@ -93,7 +93,7 @@ nxt_feature_name=NXT_HAVE_BUILTIN_CLZ
nxt_feature_run=
nxt_feature_incs=
nxt_feature_libs=
nxt_feature_test="int main() {
nxt_feature_test="int main(void) {
if (__builtin_clz(1) == 31)
return 0;
return 1;
@@ -106,7 +106,7 @@ nxt_feature_name=NXT_HAVE_BUILTIN_POPCOUNT
nxt_feature_run=
nxt_feature_incs=
nxt_feature_libs=
nxt_feature_test="int main() {
nxt_feature_test="int main(void) {
if (__builtin_popcount(5) == 2)
return 0;
return 1;
@@ -121,7 +121,7 @@ nxt_feature_incs=
nxt_feature_libs=
nxt_feature_test="int n __attribute__ ((visibility(\"default\")));
int main() {
int main(void) {
return 1;
}"
. auto/feature
@@ -134,7 +134,7 @@ nxt_feature_incs=
nxt_feature_libs=
nxt_feature_test="int n __attribute__ ((aligned(64)));
int main() {
int main(void) {
return 1;
}"
. auto/feature
@@ -153,7 +153,7 @@ nxt_feature_test="#include <stdlib.h>
return malloc(1);
}
int main() {
int main(void) {
if (f() != NULL) {
return 1;
}
@@ -172,7 +172,7 @@ nxt_feature_test="struct s {
int i;
} __attribute__ ((__packed__));
int main() {
int main(void) {
return 1;
}"
. auto/feature