technocloud-public/nginx-unit
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fixed main() prototypes in auto tests.

Browse Source 
Future releases of GCC are planning to remove[0] default support for
some old features that were removed from C99 but GCC still accepts.

We can test for these changes by using the following -Werror=
directives

  -Werror=implicit-int
  -Werror=implicit-function-declaration
  -Werror=int-conversion
  -Werror=strict-prototypes
  -Werror=old-style-definition

Doing so revealed an issue with the auto/ tests in that the test
programs always define main as

  int main()

rather than

  int main(void)

which results in a bunch of errors like

build/autotest.c:3:23: error: function declaration isn't a prototype [-Werror=strict-prototypes]
    3 |                   int main() {
      |                       ^~~~
build/autotest.c: In function 'main':
build/autotest.c:3:23: error: old-style function definition [-Werror=old-style-definition]

The fix was easy, it only required fixing the main prototype with

  find -type f -exec sed -i 's/int main() {/int main(void) {/g' {} \;

Regardless of these upcoming GCC changes, this is probably a good thing
to do anyway for correctness.

[0]: https://fedoraproject.org/wiki/Changes/PortingToModernC

Link: <https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/message/CJXKTLXJUPZ4F2C2VQOTNMEA5JAUPMBD/>
Link: <https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/message/6SGHPHPAXKCVJ6PUZ57WVDQ5TDBVIRMF/>
Reviewed-by: Alejandro Colomar <alx@nginx.com>
Signed-off-by: Andrew Clayton <a.clayton@nginx.com>
This commit is contained in:
Andrew Clayton
2022-10-28 00:17:51 +01:00
parent a3cb07df20
commit 8f0dd9478e
22 changed files with 129 additions and 129 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
auto/unix
View File

@@ -13,7 +13,7 @@ nxt_feature_libs=
nxt_feature_test="#include <unistd.h>
#include <sys/random.h>
int main() {
int main(void) {
char buf[4];
if (getrandom(buf, 4, 0) < 0) {
@@ -35,7 +35,7 @@ if [ $nxt_found = no ]; then
#include <sys/syscall.h>
#include <linux/random.h>
int main() {
int main(void) {
char buf[4];
if (syscall(SYS_getrandom, buf, 4, 0) < 0) {
@@ -56,7 +56,7 @@ if [ $nxt_found = no ]; then
nxt_feature_name=NXT_HAVE_GETENTROPY
nxt_feature_test="#include <unistd.h>
int main() {
int main(void) {
char buf[4];
if (getentropy(buf, 4) == -1) {
@@ -78,7 +78,7 @@ if [ $nxt_found = no ]; then
nxt_feature_test="#include <unistd.h>
#include <sys/random.h>
int main() {
int main(void) {
char buf[4];
if (getentropy(buf, 4) == -1) {
@@ -99,7 +99,7 @@ nxt_feature_libs=
nxt_feature_test="#include <stdlib.h>
#include <ucontext.h>
int main() {
int main(void) {
ucontext_t uc;
if (getcontext(&uc) == 0) {
@@ -126,7 +126,7 @@ if [ $nxt_found = no ]; then
#include <stdlib.h>
#include <ucontext.h>
int main() {
int main(void) {
ucontext_t uc;
if (getcontext(&uc) == 0) {
@@ -155,7 +155,7 @@ nxt_feature_libs=
nxt_feature_test="#include <stdlib.h>
#include <dlfcn.h>
int main() {
int main(void) {
void *h = dlopen(NULL, RTLD_NOW | RTLD_GLOBAL);
dlsym(h, \"\");
dlclose(h);
@@ -188,7 +188,7 @@ nxt_feature_libs=
nxt_feature_test="#include <stdlib.h>
#include <unistd.h>
int main() {
int main(void) {
setproctitle(\"%s\", \"title\");
return 0;
}"
@@ -204,7 +204,7 @@ nxt_feature_libs=
nxt_feature_test="#include <unistd.h>
#include <grp.h>
int main() {
int main(void) {
getgrouplist(\"root\", 0, NULL, NULL);
return 0;
}"