technocloud-public/nginx-unit
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Router: fixing assertion in shortage of file descriptors.

Browse Source 
Each application in router process required fd for a request queue shared
memory.  When the number of file descripts close to the limit, and port sockets
successfully opened, router needs to properly handle the errors.

This patch closes port sockets before destroying port structure to avoid
file descriptors leakage and assertion in debug build.
This commit is contained in:
Max Romanov
2021-01-25 13:13:17 +03:00
parent 6e28263d65
commit 9b76505bf7
1 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/nxt_router.c
View File

@@ -1586,6 +1586,8 @@ nxt_router_conf_create(nxt_task_t *task, nxt_router_temp_conf_t *tmcf,
ret = nxt_router_app_queue_init(task, port); ret = nxt_router_app_queue_init(task, port);
if (nxt_slow_path(ret != NXT_OK)) { if (nxt_slow_path(ret != NXT_OK)) {
nxt_port_write_close(port);
nxt_port_read_close(port);
nxt_port_use(task, port, -1); nxt_port_use(task, port, -1);
return NXT_ERROR; return NXT_ERROR;
} }