technocloud-public/nginx-unit
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Configuration: fixed buffer over-read in pattern validation.

Browse Source 
There was an undefined behavior in the validation function, caused by testing
one character after the string if a wildcard was at the end.
This commit is contained in:
Axel Duch
2020-07-28 14:51:33 +01:00
parent f1e445bdef
commit c3e6901f53
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/nxt_conf_validation.c
View File

@@ -1454,7 +1454,7 @@ nxt_conf_vldt_match_pattern(nxt_conf_validation_t *vldt,
nxt_conf_value_t *value) nxt_conf_value_t *value)
{ {
nxt_str_t pattern; nxt_str_t pattern;
nxt_uint_t i, first; nxt_uint_t i, first, last;
if (nxt_conf_type(value) != NXT_CONF_STRING) { if (nxt_conf_type(value) != NXT_CONF_STRING) {
return nxt_conf_vldt_error(vldt, "The \"match\" patterns for \"host\", " return nxt_conf_vldt_error(vldt, "The \"match\" patterns for \"host\", "
@@ -1468,8 +1468,9 @@ nxt_conf_vldt_match_pattern(nxt_conf_validation_t *vldt,
} }
first = (pattern.start[0] == '!'); first = (pattern.start[0] == '!');
last = pattern.length - 1;
for (i = first; i < pattern.length; i++) { for (i = first; i < last; i++) {
if (pattern.start[i] == '*' && pattern.start[i + 1] == '*') { if (pattern.start[i] == '*' && pattern.start[i + 1] == '*') {
return nxt_conf_vldt_error(vldt, "The \"match\" pattern must " return nxt_conf_vldt_error(vldt, "The \"match\" pattern must "
"not contain double \"*\" markers."); "not contain double \"*\" markers.");