technocloud-public/nginx-unit
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

TLS certificates should be freed per listener.

Browse Source 
This fixes memory leak if configuration uses more than one TLS cerificate.
This commit is contained in:
Igor Sysoev
2019-02-22 17:32:38 +03:00
parent 3280b826e3
commit c96b2baca5
1 changed files with 9 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/nxt_router.c
View File

@@ -2910,6 +2910,7 @@ nxt_router_conf_release(nxt_task_t *task, nxt_socket_conf_joint_t *joint)
rtcf, rtcf->count); rtcf, rtcf->count);
if (--skcf->count != 0) { if (--skcf->count != 0) {
skcf = NULL;
rtcf = NULL; rtcf = NULL;
app = NULL; app = NULL;
@@ -2923,6 +2924,14 @@ nxt_router_conf_release(nxt_task_t *task, nxt_socket_conf_joint_t *joint)
nxt_thread_spin_unlock(lock); nxt_thread_spin_unlock(lock);
if (skcf != NULL) {
#if (NXT_TLS)
if (skcf->tls != NULL) {
task->thread->runtime->tls->server_free(task, skcf->tls);
}
#endif
}
if (app != NULL) { if (app != NULL) {
nxt_router_app_use(task, app, -1); nxt_router_app_use(task, app, -1);
} }
@@ -2933,12 +2942,6 @@ nxt_router_conf_release(nxt_task_t *task, nxt_socket_conf_joint_t *joint)
if (rtcf != NULL) { if (rtcf != NULL) {
nxt_debug(task, "old router conf is destroyed"); nxt_debug(task, "old router conf is destroyed");
#if (NXT_TLS)
if (skcf->tls != NULL) {
task->thread->runtime->tls->server_free(task, skcf->tls);
}
#endif
nxt_router_access_log_release(task, lock, rtcf->access_log); nxt_router_access_log_release(task, lock, rtcf->access_log);
nxt_mp_thread_adopt(rtcf->mem_pool); nxt_mp_thread_adopt(rtcf->mem_pool);