technocloud-public/nginx-unit
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Node.js: avoided use of request struct for debug logging.

Browse Source 
This fixes a crash on exit of Node.js application.  The crash reproduced
on Ubuntu 20.10 with Node.js v15.1.0.  Tests 'test_node_websockets_two_clients'
and 'test_node_websockets_7_13_1__7_13_2'.

The reason of the crash is using request struct which was already freed.

The issue was introduced in 5be509fda29e.
This commit is contained in:
Max Romanov
2020-12-07 17:56:18 +03:00
parent 07789a23e9
commit db42527b1b
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/nodejs/unit-http/unit.cpp
View File

@@ -1000,19 +1000,19 @@ Unit::websocket_set_sock(napi_env env, napi_callback_info info)
void
Unit::conn_destroy(napi_env env, void *r, void *finalize_hint)
{
nxt_unit_req_debug((nxt_unit_request_info_t *) r, "conn_destroy: %p", r);
nxt_unit_req_debug(NULL, "conn_destroy: %p", r);
}
void
Unit::sock_destroy(napi_env env, void *r, void *finalize_hint)
{
nxt_unit_req_debug((nxt_unit_request_info_t *) r, "sock_destroy: %p", r);
nxt_unit_req_debug(NULL, "sock_destroy: %p", r);
}
void
Unit::resp_destroy(napi_env env, void *r, void *finalize_hint)
{
nxt_unit_req_debug((nxt_unit_request_info_t *) r, "resp_destroy: %p", r);
nxt_unit_req_debug(NULL, "resp_destroy: %p", r);
}