technocloud-public/nginx-unit
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

PHP: added check for the ".php" extension.

Browse Source 
A check for the ".php" extension is added to prevent execution of files
with arbitrary extensions in cases where "index" and "script" options
aren't used.
This commit is contained in:
Valentin Bartenev
2020-01-28 19:18:26 +03:00
parent 4024b18bcc
commit f860c20a96
1 changed files with 11 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/nxt_php_sapi.c
View File

@@ -599,20 +599,27 @@ nxt_php_request_handler(nxt_unit_request_info_t *req)
path.start = nxt_unit_sptr_get(&r->path); path.start = nxt_unit_sptr_get(&r->path);
if (nxt_php_script_filename.start == NULL) { if (nxt_php_script_filename.start == NULL) {
nxt_str_null(&script_name);
ctx->path_info.start = (u_char *) strstr((char *) path.start, ".php/"); ctx->path_info.start = (u_char *) strstr((char *) path.start, ".php/");
if (ctx->path_info.start != NULL) { if (ctx->path_info.start != NULL) {
ctx->path_info.start += 4; ctx->path_info.start += 4;
path.length = ctx->path_info.start - path.start; path.length = ctx->path_info.start - path.start;
ctx->path_info.length = r->path_length - path.length; ctx->path_info.length = r->path_length - path.length;
}
if (path.start[path.length - 1] == '/') { } else if (path.start[path.length - 1] == '/') {
script_name = nxt_php_index; script_name = nxt_php_index;
} else { } else {
script_name.length = 0; if (nxt_slow_path(path.length < 4
script_name.start = NULL; || nxt_memcmp(path.start + (path.length - 4),
".php", 4)))
{
nxt_unit_request_done(req, NXT_UNIT_ERROR);
return;
}
} }
ctx->script_filename.length = nxt_php_root.length + path.length ctx->script_filename.length = nxt_php_root.length + path.length