technocloud-public/nginx-unit
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

fix: Take options as well as requestListener (#1091)

Browse Source 
* Take options as well as requestListener

Unit-http have not kept up with the signature of nodejs's http package
development. Nodejs allows an optional `options` object to be passed to
the `createServer` function, we didn't. This resulted in function
signature errors when user code that did make use of the options arg
tried to call unit's replaced function.

This change changes the signature to be more in line with how nodejs
does it discarding it and printing a message to stdout.

* Add test file to start node application with options

* Add changes to docs/changes.xml

Closes: https://github.com/nginx/unit/issues/1043
This commit is contained in:
Gabor Javorszky
2024-02-14 18:16:01 +00:00
committed by GitHub
parent 2b0d93d1a7
commit fbeb2065b1
5 changed files with 27 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
docs/changes.xml
View File

@@ -53,6 +53,12 @@ NGINX Unit updated to 1.32.0.
</para>
</change>
<change type="bugfix">
<para>
http.createServer() now accepts "options" argument introduced in Node.js v9.6.0, v8.12.0.
</para>
</change>
<change type="feature">
<para>
conditional access logging.