fix: Take options as well as requestListener (#1091)
* Take options as well as requestListener Unit-http have not kept up with the signature of nodejs's http package development. Nodejs allows an optional `options` object to be passed to the `createServer` function, we didn't. This resulted in function signature errors when user code that did make use of the options arg tried to call unit's replaced function. This change changes the signature to be more in line with how nodejs does it discarding it and printing a message to stdout. * Add test file to start node application with options * Add changes to docs/changes.xml Closes: https://github.com/nginx/unit/issues/1043
This commit is contained in:
@@ -11,8 +11,8 @@ const {
|
||||
ServerResponse,
|
||||
} = require('./http_server');
|
||||
|
||||
function createServer (requestHandler) {
|
||||
return new Server(requestHandler);
|
||||
function createServer (options, requestHandler) {
|
||||
return new Server(options, requestHandler);
|
||||
}
|
||||
|
||||
const http = require("http")
|
||||
|
||||
@@ -5,6 +5,7 @@
|
||||
|
||||
'use strict';
|
||||
|
||||
const { stderr } = require('process');
|
||||
const EventEmitter = require('events');
|
||||
const http = require('http');
|
||||
const util = require('util');
|
||||
@@ -413,7 +414,14 @@ ServerRequest.prototype._read = function _read(n) {
|
||||
};
|
||||
|
||||
|
||||
function Server(requestListener) {
|
||||
function Server(options, requestListener) {
|
||||
if (typeof options === 'function') {
|
||||
requestListener = options;
|
||||
options = {};
|
||||
} else {
|
||||
stderr.write("http.Server constructor was called with unsupported options, using default settings\n");
|
||||
}
|
||||
|
||||
EventEmitter.call(this);
|
||||
|
||||
this.unit = new unit_lib.Unit();
|
||||
|
||||
Reference in New Issue
Block a user