Commit Graph

1944 Commits

Author SHA1 Message Date
Max Romanov
86138113eb Adding explicit app reference to nxt_router_app_port_release().
port->app field is not thread safe and should be used in main thread only.
To release port after request processing, application reference should be
obtained from corresponding request descriptor.
2021-10-28 17:46:50 +03:00
Valentin Bartenev
1441f42b5d Fixed memleaks if PID checks fail in nxt_port_incoming_port_mmap().
Memory allocated for "mem" and "mmap_handler" leaked in that case.
Also removed one dead assigment of "hdr" pointer.
2021-10-27 20:37:34 +03:00
Valentin Bartenev
561dbeb98d Fixed a potential descriptor leak if mmap() failed. 2021-10-26 19:31:43 +03:00
Valentin Bartenev
7bf6253941 Custom implementation of Base64 decoding function.
Compared to the previous implementation based on OpenSSL, the new implementation
has these advantages:

 1. Strict and reliable detection of invalid strings, including strings with
    less than 4 bytes of garbage at the end;

 2. Allows to use Base64 strings without '=' padding.
2021-10-26 15:43:44 +03:00
Andrei Belov
7503cc96df Packages: removed support for EOL'ed Debian/Ubuntu distros.
While here, default debhelper compat level bumped to 11 (this is the
version installed out of the box on Ubuntu 18.04 "bionic" which is
the oldest one from supported distros).
2021-10-21 15:28:58 +03:00
Andrei Belov
0900edb10d Packages: added Ubuntu 21.10 "impish" support. 2021-10-21 13:23:25 +03:00
Andrei Belov
314ca5c8c9 Packages: fixed dependency tracking for Go and Java modules on RHEL7. 2021-10-19 12:20:36 +03:00
Andrei Zeliankou
39adb292d5 Tests: style. 2021-10-18 01:10:11 +01:00
Zhidao HONG
78a4063063 Removed unused declarations.
Declarations became unused after 6976d36be926.

No functional changes.
2021-10-12 10:32:17 +08:00
Zhidao HONG
5fa5b1464f Configuration: automatic migration to the new "share" behavior. 2021-10-09 10:44:31 +08:00
Artem Konev
af283833dd Merged with the default branch. 2021-10-08 13:51:14 +01:00
Artem Konev
cdaa8e2523 Fixed invalid call sequence in nxt_tls_ticket_key_callback().
The bug has been introduced in 0bca988e9541.
2021-10-08 13:44:14 +01:00
Andrei Zeliankou
5c20d43eff Tests: added tests for variables in "chroot". 2021-10-05 12:43:05 +01:00
Andrei Zeliankou
a59557ccd7 Tests: added tests for variables in "share". 2021-10-05 12:42:41 +01:00
Andrei Zeliankou
22028549c6 Tests: added tests for "share" option with arrays. 2021-10-05 03:24:56 +01:00
Valentin Bartenev
8db8330f84 Static: removed surplus assignment.
It's not needed after 69d823e5710a.
Found by Clang Static Analyzer.
2021-10-04 15:33:56 +03:00
Valentin Bartenev
9baf22e7bf Static: fixed possible descriptor leak introduced in a946d8cd7f8c. 2021-10-04 15:33:04 +03:00
Zhidao HONG
95e6535909 Static: multiple paths in the "share" option. 2021-10-01 10:03:55 +08:00
Zhidao HONG
c5220944d2 Static: variables in the "share" option.
This commit supports variable in the "share" option, the finding path to
file serve is the value from "share". An example:
{
    "share": "/www/data/static$uri"
}
2021-09-30 22:17:28 +08:00
Zhidao HONG
37144d6849 Static: variables in the "chroot" option. 2021-09-28 23:08:26 +08:00
Konstantin Pavlov
2fc64c65bc Regenerated Dockerfiles. 2021-09-21 14:03:54 +03:00
Konstantin Pavlov
d51b3bbfeb Docker: bumped versions.
Minimal image now uses Debian 11 "Bullseye" as a base.

Language versions are bumped to:
- Go 1.17
- Node 16
- Perl 5.34
- Ruby 3.0
2021-09-21 14:03:23 +03:00
Max Romanov
c07f3d3ff6 Fixed WebSocket connection hang issue after listener reconfigure.
Because the configuration values were read from the listener's configuration,
an established WebSocket connection was unable to work properly (i. e. stuck)
if the listener was removed.  The correct source of configuration values is the
request config joint.

This is related to issue #581 on GitHub.
2021-09-20 09:01:08 +03:00
Max Romanov
d21ebcce83 Fixing build with glibc 2.34.
Explicitly using the sysconf() call to obtain the minimum thread stack size
instead of the PTHREAD_STACK_MIN macro.

This closes #576 PR on GitHub.
2021-09-14 19:35:49 +03:00
Zhidao HONG
a336928e10 Router: refactored variable pass.
Since the "pass" option supports both strings and variables, a generic
nxt_var_t structure can be used in the configuration phase, and the "name"
field in actions is redundant.

No functional changes.
2021-09-07 21:13:44 +08:00
Zhidao HONG
9c1894bf77 Var: keeping raw variable string for debug. 2021-09-06 19:27:45 +08:00
Valentin Bartenev
dbc5a742fd TLS: refactored nxt_tls_ticket_key_callback().
Deduplicated code and improved style.
No functional changes.
2021-08-25 10:33:32 +03:00
Valentin Bartenev
f50b07c21d Version bump. 2021-08-24 14:38:24 +03:00
Artem Konev
bd9f8ada0b Fixed a typo in changes.xml. 2021-08-20 06:56:53 +03:00
Valentin Bartenev
13c0025dfa Unit 1.25.0 release. 2021-08-19 17:55:12 +03:00
Valentin Bartenev
66e986fc19 Generated Dockerfiles for Unit 1.25.0. 2021-08-19 17:52:54 +03:00
Valentin Bartenev
9aefc73476 Added version 1.25.0 CHANGES. 2021-08-19 17:48:21 +03:00
Valentin Bartenev
90680c2caf Reordered changes for 1.25.0 by significance (subjective). 2021-08-19 17:43:04 +03:00
Artem Konev
8b3a8eaf98 Edited changes.xml for the 1.25.0 release. 2021-08-19 16:15:07 +03:00
Andrey Suvorov
e0aa132172 Added TLS session tickets support. 2021-08-17 16:52:32 -07:00
Andrei Belov
3bd60e317c Packages: added Debian 11 "bullseye" support. 2021-08-17 16:45:51 +03:00
Zhidao HONG
48a9399f23 Introduced the generic API nxt_buf_dummy_completion().
No functional changes.
2021-08-12 17:39:00 +08:00
Zhidao HONG
598f1493f6 Log: renamed related variables "log" as "_log" to prevent conflicts. 2021-08-12 17:41:21 +08:00
Max Romanov
b586707c86 Java: upgrading third-party components. 2021-08-12 14:55:51 +03:00
Oisin Canty
039d032dd6 Tests: client IP address replacement. 2021-08-12 08:23:23 +00:00
Oisin Canty
ca373aaccd Router: client IP address replacement.
This commit introduces the replacement of the client address based on the value
of a specified HTTP header.  This is intended for use when Unit is placed
behind a reverse proxy like nginx or a CDN.

You must specify the source addresses of the trusted proxies.  This can be
accomplished with any valid IP pattern supported by Unit's match block:

["10.0.0.1", "10.4.0.0/16", "!192.168.1.1"]

The feature is configured per listener.

The client address replacement functionality only operates when there is a
source IP match and the specified header is present.  Typically this would be
an 'X-Forwarded-For' header.

{
    "listeners": {
        "127.0.0.1:8080": {
            "client_ip": {
                "header": "X-Forwarded-For",
                "source": [
                    "10.0.0.0/8"
                ]
            },
            "pass": "applications/my_app"
        },
    }
}

If a request occurs and Unit receives a header like below:

"X-Forwarded-For: 84.123.23.23"

By default, Unit trusts the last rightmost IP in the header, so REMOTE_ADDR
will be set to 84.123.23.23 if the connection originated from 10.0.0.0/8.

If Unit runs behind consecutive reverse proxies and receives a header similar
to the following:

"X-Forwarded-For: 84.123.23.23, 10.0.0.254"

You will need to enable "recursive" checking, which walks the header from
last address to first and chooses the first non-trusted address it finds.

{
    "listeners": {
        "127.0.0.1:8080": {
            "client_ip": {
                "header": "X-Forwarded-For",
                "source": [
                    "10.0.0.0/8"
                ]
                "recursive": true,
            },
            "pass": "applications/my_app"
        },
    }
}

If a connection from 10.0.0.0/8 occurs, the chain is walked.  Here, 10.0.0.254
is also a trusted address so the client address will be replaced with
84.123.23.23.

If all IP addresses in the header are trusted, the client address is set to
the first address in the header:

If 10.0.0.0/8 is trusted and "X-Forwarded-For: 10.0.0.3, 10.0.0.2, 10.0.0.1",
the client address will be replaced with 10.0.0.3.
2021-08-12 08:23:16 +00:00
Oisin Canty
73ea6a1c3a Introduced nxt_sockaddr_parse_optport() for addresses w/o ports. 2021-08-12 08:23:09 +00:00
Max Romanov
9988569bea Tests: initialising log params before first _print_log(). 2021-08-11 19:01:16 +03:00
Max Romanov
5f67d30ec7 Tests: retrying directory remove if resource is busy. 2021-08-11 19:01:04 +03:00
Max Romanov
3580842d34 Python: fixing misprint in error message. 2021-08-09 10:15:00 +03:00
Max Romanov
1a85ad378f Java: upgrading third-party components. 2021-08-09 10:14:57 +03:00
Oisin Canty
60cf139961 Router: fixed crash when matching an empty address pattern array.
A crash would occur when the router tried to match an
against an empty address pattern array.

The following configuration was used to reproduce the
issue:

{
    "listeners": {
        "127.0.0.1:8082": {
            "pass": "routes"
        }
    },
    "routes": [
        {
            "match": {
                "source": []
            },
            "action": {
                "return": 200
            }
        }
    ]
}
2021-08-05 16:00:01 +00:00
Zhidao HONG
44fe31dc61 Added a changelog for ae4f067a9ea4. 2021-08-04 18:09:50 +08:00
Zhidao HONG
d16cf04167 Router: fixed segmentation fault.
In the case that routes or upstreams is empty and the pass option is a variable.
If the resolved pass is routes or upstreams, a segment error occurred.
2021-08-02 12:30:38 +08:00
Max Romanov
db03dfad67 Fixed dead assignments.
Found by Clang Static Analyzer.
2021-08-03 13:59:27 +03:00