Commit Graph

598 Commits

Author SHA1 Message Date
Max Romanov
bd1eb7b502 RPC error message size fixed.
In case of RPC error, special error message passed to handler.
Field 'size' expected to be 0 in this case because in contains fake
empty buffer.
2019-02-25 18:09:37 +03:00
Valentin Bartenev
d8c0a0dbe2 Disabled useless code in nxt_router_listen_socket_error().
It doesn't do anything useful, among creating a JSON message and logging it
to debug log.  Besides that it causes segmentation fault if the RPC handler
is triggered with an empty buffer due to exiting of the main process.
2019-02-25 15:10:44 +03:00
Valentin Bartenev
c5563d142d Removed surplus check for NUL in nxt_http_validate_host().
Such header fields are already rejected by HTTP parser.
2019-02-23 14:48:33 +03:00
Alexander Borisov
608e09e9de Improvement and unification of version processing in build scripts.
This also eliminates expressions that incompatible with BSD make, thus fixing
installation of Node.js module on FreeBSD (broken by dace60fc4926).
2019-02-22 16:31:44 +03:00
Igor Sysoev
c96b2baca5 TLS certificates should be freed per listener.
This fixes memory leak if configuration uses more than one TLS cerificate.
2019-02-22 17:32:38 +03:00
Sergey Kandaurov
3280b826e3 Initializing incoming buffer queue in a proper place.
In case nxt_unit_tracking_read() failed, execution would jump to the error path,
where it could try to release buffers from uninitialized yet incoming_buf queue.
2019-02-21 16:30:59 +03:00
Valentin Bartenev
2d4697dbbe Validation and normalization of request host. 2019-02-19 20:25:25 +03:00
Igor Sysoev
acb5b0aad7 Ignoring HUP signal in main process. 2019-02-18 18:34:20 +03:00
Igor Sysoev
bb11e9036f Fixed memory leak on response body sending failure. 2019-02-18 17:28:55 +03:00
Valentin Bartenev
2a6b54c230 Rejecting requests with duplicate "Content-Length". 2019-02-18 16:51:30 +03:00
Valentin Bartenev
a2cbe890a1 Rejecting requests with invalid "Content-Length". 2019-02-07 17:40:27 +03:00
Igor Sysoev
fd6a6a5514 Fixed processing Unix listening socket failures.
This is related to issue #198 on GitHub.
2019-01-21 18:39:19 +03:00
Igor Sysoev
23a6a8e451 Testing correct value. 2019-01-18 16:18:36 +03:00
Valentin Bartenev
fac0ef29d5 Version bump. 2018-12-24 20:31:45 +03:00
Valentin Bartenev
27394118b3 Python: fixed error reporting on initialization of applications.
PyErr_Print() writes traceback to "sys.stderr", which is a file object that
can buffer the output.  If the process exits immediately, the buffer can be
destroyed before flushing to the log.  As a result, the user doesn't see
the traceback.

Now Py_Finalize() is also called in case of any errors during initialization.
It finalizes the interpreter and flushes all data.
2018-12-20 15:47:10 +03:00
Valentin Bartenev
1ce7e860b2 Python: cleanup of nxt_python_init().
- Removed surplus NULL assignments;
 - Added missing nxt_slow_path();
 - Style cleanup.
2018-12-20 15:47:10 +03:00
Artem Konev
9c03079e3a Python: fixed a typo in path error message. 2018-12-20 14:17:58 +03:00
Valentin Bartenev
cebec46353 Python: replaced PyErr_PrintEx(1) with PyErr_Print().
These function calls are equivalent.
No functional changes.
2018-12-19 20:06:53 +03:00
Alexander Borisov
98e8f366da Node.js: removed value checking for headers. 2018-12-19 15:57:07 +03:00
Alexander Borisov
d9dad07934 Node.js: removed unused _implicitHeader() function. 2018-12-19 15:57:04 +03:00
Alexander Borisov
d6f38a3268 Node.js: added check for libunit version at compile time. 2018-12-19 15:56:57 +03:00
Alexander Borisov
c55f329ecf libunit: added generation of version header file. 2018-12-19 15:56:54 +03:00
Alexander Borisov
ab461437b5 Node.js: checking for exception after running JS code from C++. 2018-12-19 15:56:37 +03:00
Alexander Borisov
dcf51274ce Node.js: checking uniqueness of HTTP headers for different case. 2018-12-19 15:56:30 +03:00
Alexander Borisov
607653c0f1 Node.js: calling write callback asynchronously. 2018-12-19 15:56:13 +03:00
Alexander Borisov
704fe556b4 Node.js: style fixes.
No functional changes.
2018-12-19 15:56:09 +03:00
Alexander Borisov
dc16885b60 Node.js: changed the unit-http socket constructor.
Third-party file descriptors are not supported.
Socket "readable" and "writable" options are set true by default.
2018-12-19 15:56:06 +03:00
Alexander Borisov
f47a5db506 Node.js: napi_call_function() replaced with napi_make_callback().
The sequence of napi_open_callback_scope(),
napi_call_function(), and napi_close_callback_scope() functions calls
executes the provided JS code and all functions enqueued by
process.nextTick() and Promises during this execution.
2018-12-19 15:56:01 +03:00
Alexander Borisov
13c9ebccca Node.js: changed the 'data' event calling sequence for the request.
The problem is caused by Promises' inconsistency.
The 'date' event could have been triggered before the user has started
listening for it.  To resolve the issue, we override the 'on' method of
the request's emitter.
2018-12-19 15:55:58 +03:00
Alexander Borisov
de3c062c6e Node.js: buffering HTTP headers before writing the body. 2018-12-19 15:55:54 +03:00
Valentin Bartenev
aeb026c8ab Node.js: removed unused dependency. 2018-12-12 19:57:15 +03:00
Valentin Bartenev
db63191719 PHP: fixed "disable_functions" and "disable_classes" options.
It turned out they need additional processing to work.
This closes #183 issue on GitHub.
2018-11-27 22:06:39 +03:00
Valentin Bartenev
262578dc71 PHP: workaround for bug #71041.
Since PHP 7, a zend_signal_startup() call is required if the interpreter
was built with ZEND_SIGNALS defined; such a call was added in 3fd76e4ce70a.

However, the zend_signal_startup() export is missing from the PHP library;
as the result, dlopen() fails with the 'Undefined symbol "zend_signal_startup"'
error while loading the PHP module.

Meanwhile, if PHP is built without ZTS, the zend_signal_startup() call can
be omitted; otherwise, the missing call causes segmentation fault.

The PHP fix already was committed to upstream, but we still have to deal
with numerous unpatched versions remaining at large.

See the related PHP bug: https://bugs.php.net/bug.php?id=71041
2018-11-22 20:23:43 +03:00
Valentin Bartenev
adf22b6a0d PHP: fixed compatibility with ZTS.
This closes #184 issue on GitHub.
2018-11-21 18:22:19 +03:00
Valentin Bartenev
e4d9cffedf Version bump. 2018-11-15 20:08:43 +03:00
Valentin Bartenev
2b4d83cbd8 Node.js: npm package readme cleanup. 2018-11-15 15:53:35 +03:00
Alexander Borisov
5c2021f834 Node.js: res.write() must return a bool value. 2018-11-15 14:42:51 +03:00
Alexander Borisov
fb18a09cd7 Node.js: fixed handling of response header fields.
This fixes two issues:

- values for mutiple header fields with the same name
  passed as arrays were converted to string;

- the type of field value wasn't preserved as required
  by specification.
2018-11-15 15:21:52 +03:00
Alexander Borisov
06b404feb1 Node.js: added correct exit processing.
Node.js processes didn't exit after the changes in b9f7635e6be2,
as the quit command from port wasn't handled by the module.
2018-11-15 15:39:34 +03:00
Alexander Borisov
71f4cb9134 Node.js: added reference count increment for the Unit object.
We increase the number to the Unit object so that it lives forever.
This is necessary so that the garbage collector does not delete the Unit object.
2018-11-15 15:24:45 +03:00
Valentin Bartenev
b033fb329f Fixed lvlhsh test on 64-bit big-endian systems.
The nxt_murmur_hash2() generated 4-byte hash that was stored in uintptr_t,
which was 8 bytes long on 64-bit systems.  At each iteration, it took the
previous key and hashed it again.

The problem was that it took only the first 4 bytes of the key, and these
4 bytes were always zero on 64-bit big-endian system.  That resulted in
equal keys at each iteration.

The bug was discovered on IBM/S390x.
2018-11-15 13:00:58 +03:00
Valentin Bartenev
08e0082e07 Fixed discovering of modules on 64-bit big-endian systems.
The nxt_conf_map_object() function used nxt_int_t for NXT_CONF_MAP_INT, which
was 8 bytes long on 64-bit systems.

But the nxt_port_main_start_worker_handler() used it to map into the int field
of the nxt_common_app_conf_t structure, which was 4 bytes.  As the result, on
a 64-bit big-endian system all the meaningful module type numbers were assigned
into the gap above the "type" field.

The bug was discovered on IBM/S390x.
2018-11-15 11:59:03 +03:00
Igor Sysoev
92ddc15a84 Checking error states in I/O handlers. 2018-11-13 19:04:48 +03:00
Valentin Bartenev
ff9bed64da Fixed nxt_openssl_chain_file() return type.
This closes #182 issue on GitHub.
Thanks to 洪志道 (Hong Zhi Dao).
2018-11-13 18:43:39 +03:00
Valentin Bartenev
4f4a2d8c63 Fixed "freed pointer is out of pool" alerts.
The issue was caused by misplacement of allocated blocks in rbtree due
to broken comparison function if the distance between two allocations
did not fit into intptr_t.  As the result, nxt_mp_free() could have
failed to find the allocation.

In particular, it was mostly observed when Unit was compiled with
musl C library on 32-bits systems.

This closes #118 issue on GitHub.
2018-11-10 07:38:43 +03:00
Andrey Zelenkov
4a77c447ba Node.js: socket.js improvements.
- Fixed handling of the "options" parameter in Socket() constructor;
- Now the connect() method returns "this";
- Deduplicated the address() method;
- Added missing "callback" argument to the end() method;
- Now the destroy() method returns "this";
- Added "timeout" argument type check in the setTimeout() method.
2018-11-06 19:04:01 +03:00
Andrey Zelenkov
b7442743cf Node.js: fixed typo in naming rawHeaders() method of request. 2018-11-01 19:10:32 +03:00
Alexander Borisov
c838c3bd15 Node.js: added async request execution. 2018-10-31 15:51:51 +03:00
Valentin Bartenev
3b0afb1681 Version bump. 2018-10-31 16:31:14 +03:00
Alexander Borisov
5b3d3e0a88 Node.js: additional type check for response.setHeader value. 2018-10-24 16:21:53 +03:00