technocloud-public/nginx-unit
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity
1,447 Commits 1 Branch 0 Tags
f46ef1b121e421eb4b773dd9a3a951bb021b66ff
Commit Graph

1447 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Igor Sysoev
04143c8c7e Fixed crash that occurs when idle connections are closed forcibly. 2020-04-15 14:54:09 +03:00
Igor Sysoev
e616d0915c Disabled epoll error processing when socket events are inactive. 2020-04-15 14:54:09 +03:00
Max Romanov
9a422b8984 Completing chained shared memory buffers. 
After 41331471eee7 completion handlers should complete next buffer in chain.
Otherwise buffer memory may leak.

Thanks to Peter Tkatchenko for reporing the issue and testing fixes.
 2020-04-14 16:11:13 +03:00
Andrei Zeliankou
3c58a4bfc1 Tests: added test with rescheduling requests. 2020-04-14 03:02:16 +01:00
Andrei Zeliankou
0bfa09dfa0 Tests: minor fixes and style. 2020-04-14 02:35:04 +01:00
Max Romanov
58cc13ab29 Resolving a racing condition while adding ports on the app's side. 
An earlier attempt (ad6265786871) to resolve this condition on the
router's side added a new issue: the app could get a request before
acquiring a port.
 2020-04-10 16:21:58 +03:00
Valentin Bartenev
c7f5c1c664 Controller: improved handling of unix domain control socket. 
One of the ways to detect Unit's startup and subsequent readiness to accept
commands relies on waiting for the control socket file to be created.
Earlier, it was unreliable due to a race condition between the client's
connect() and the daemon's listen() calls after the socket's bind() call.

Now, unix domain listening sockets are created with a nxt_listen_socket_create()
call as follows:

   s = socket();
   unlink("path/to/socket.tmp")
   bind(s, "path/to/socket.tmp");
   listen(s);
   rename("path/to/socket.tmp", "path/to/socket");

This eliminates a time-lapse when the socket file is already created but nobody
is listening on it yet, which therefore prevents the condition described above.

Also, it allows reliably detecting whether the socket is being used or simply
wasn't cleaned after the daemon stopped abruptly.  A successful connection to
the socket file means the daemon has been started; otherwise, the file can be
overwritten.
 2020-04-08 15:15:24 +03:00
Valentin Bartenev
a6d9efcee1 Controller: fixed cleaning up of control socket file in some cases. 
Previously, the unix domain control socket file might have been left
in the file system after a failed nxt_listen_socket_create() call.
 2020-04-08 15:15:24 +03:00
Valentin Bartenev
555d595f38 Removed unused code related to testing of address binding. 2020-04-08 15:15:24 +03:00
Valentin Bartenev
27c1e26856 Controller: eliminated extra control socket's sockaddr copying. 2020-04-08 15:15:24 +03:00
Max Romanov
ce53d6bdb1 Node.js: fixing Server.listen() method. 
This is required for Express framework compatibility.

This closes #418 issue on GitHub.
 2020-04-08 14:44:53 +03:00
Max Romanov
792ef9d3c7 Fixing 'find & add' racing condition in connected ports hash. 
Missing error log messages added.
 2020-04-06 16:52:11 +03:00
Andrei Zeliankou
a49023229e Tests: use "return" action in upstream tests. 2020-04-03 01:49:18 +01:00
Andrei Zeliankou
d7aa514d6a Tests: added notification on "read_timeout" expiration. 2020-04-03 01:46:59 +01:00
Andrei Zeliankou
2bb8b3d88a Tests: minor fixes. 2020-04-03 01:03:26 +01:00
Valentin Bartenev
be943c9fd4 Fixed build with Clang 10, broken by 32578e837322. 
This silences the -Wimplicit-int-float-conversion warning.
 2020-04-01 18:33:48 +03:00
Andrei Zeliankou
5954839773 Tests: added tests for rational numbers in upstream server weight. 2020-03-30 18:44:50 +01:00
Igor Sysoev
01e957ef64 Rational number support in upstream server weight. 2020-03-30 19:47:01 +03:00
Valentin Bartenev
68c6b67ffc Configuration: support for rational numbers. 2020-03-30 19:37:58 +03:00
Max Romanov
0935630cba Fixing application process infinite loop. 
Main process exiting before app process init may have caused hanging.
 2020-03-30 14:18:51 +03:00
Max Romanov
ab7b42a072 Handling change file message in libunit. 
This is required for proper log file rotation action.
 2020-03-30 14:18:41 +03:00
Max Romanov
82b899b136 Attributing libunit logging function for arguments validation. 2020-03-30 14:08:20 +03:00
Andrei Zeliankou
f94e31b294 Tests: added tests for "location" option. 2020-03-27 17:29:45 +00:00
Andrei Zeliankou
6e5b5d2a0b Tests: added tests for "return" action. 2020-03-27 15:50:09 +00:00
Andrei Zeliankou
5f2d07019c Tests: increase default "read_timeout" to 60s in message_read(). 2020-03-27 15:48:39 +00:00
Valentin Bartenev
c63b498f94 Implemented "location" option for "return" action. 
This allows to specify redirects:

  {
      "action": {
          "return": 301,
          "location": "https://www.example.com/"
      }
  }
 2020-03-21 01:39:00 +03:00
Valentin Bartenev
35d6f84426 Added nxt_is_complex_uri_encoded()/nxt_encode_complex_uri(). 2020-03-27 17:22:52 +03:00
Valentin Bartenev
d4b4cb0438 Updated URI escaping table for better conformity with RFC 3986. 
Now '>', '<', '"', '^', '\', '}', '|', '{', and '`' are also escaped.
 2020-03-27 17:22:52 +03:00
Valentin Bartenev
8d727774e3 Implemented "return" action. 
The "return" action can be used to immediately generate a simple HTTP response
with an arbitrary status:

  {
      "action": {
          "return": 404
      }
  }

This is especially useful for denying access to specific resources.
 2020-03-27 17:22:52 +03:00
Valentin Bartenev
5f9c4754cb Initialization of the action object made more consistent. 2020-03-27 17:22:52 +03:00
Andrei Zeliankou
8532cf6ae6 Tests: added tests for comments in JSON. 2020-03-25 19:40:08 +00:00
Andrei Zeliankou
2e4ad9fbc0 Tests: UTF-8 BOM test. 2020-03-25 19:31:42 +00:00
Valentin Bartenev
fd8e524b82 Configuration: fixed comments parsing. 
Unclosed multi-line comments and "/" at the end of JSON shouldn't be allowed.
 2020-03-25 19:14:15 +03:00
Andrei Zeliankou
48ad88ee72 Tests: increase default "read_timeout" value to 60s. 
This change is necessary to avoid errors on slow hosts.

Also slightly reworked argument passing to the recvall() function.
 2020-03-23 19:18:26 +00:00
Andrei Zeliankou
ac9ca6d75c Tests: added notification on unsuccessful connect(). 2020-03-23 19:12:22 +00:00
Andrei Zeliankou
b0161df42e Tests: wait for unit.pid file before running tests. 
Waiting for control.unit.sock was replaced by unit.pid due to current problem
with race between connect() and listen() calls for control.unit.sock.

This change should be reverted after fix.
 2020-03-23 19:09:29 +00:00
Konstantin Pavlov
bac93637ed Fixed filepath in the image checksum file. 2020-03-19 13:16:37 +03:00
Andrei Zeliankou
3fd4b4cfab Tests: rearranging functions in main.py. 2020-03-23 02:13:46 +00:00
Andrei Zeliankou
c7cc247baa Tests: terminate unitd process on exit(). 2020-03-23 02:12:44 +00:00
Max Romanov
59e06e4910 Completing buffers immediately 
This fixes crash introduced in 039b00e32e3d.
 2020-03-19 22:04:43 +03:00
Max Romanov
c26fbbe53a Completing request header buffers to avoid memory leak. 
Before this fix, only persistent connection request buffers were completed.

This issue was introduced in dc403927ab0b.
 2020-03-19 20:43:35 +03:00
Andrei Zeliankou
93207d4a8c Tests: test_python_procman.py refactored. 2020-03-19 03:17:00 +00:00
Andrei Zeliankou
06c790ac1e Tests: fixed prerequisite in test_share_fallback.py. 2020-03-19 03:15:50 +00:00
Max Romanov
c6f9ca79e6 Fixing body fd access racing condition. 
To avoid closing the body fd prematurely, the fd value is moved from
the request struct to the app link.  The body fd should not be closed
immediately after the request is sent to the application due to possible
request rescheduling.
 2020-03-17 14:44:11 +03:00
Max Romanov
efbcd517fc Checking sendfile() availability in configure. 
Removing SF_NODISKIO flag for FreeBSD sendfile() check because it
is not used yet and to support DragonFlyBSD.

This closes #414 issue on GitHub.
 2020-03-17 14:44:06 +03:00
Valentin Bartenev
b7f0e09de0 Version bump. 2020-03-16 13:27:10 +03:00
Konstantin Pavlov
3b94102f20 Added checksum generation to make dist target. 
While at it, clean up dist artifacts on make clean.
 2020-03-13 17:42:08 +03:00
Konstantin Pavlov
7181a661c5 Added a target to export docker images as tarballs 2020-03-13 17:35:47 +03:00
Andrei Zeliankou
baf9230398 Tests: skip "close failed" alert in test_proxy_parallel test. 2020-03-12 17:14:16 +00:00
Valentin Bartenev
b3c8a7b33a Added tag 1.16.0 for changeset 8bab088952dd 2020-03-12 18:35:33 +03:00