Future releases of GCC are planning to remove[0] default support for
some old features that were removed from C99 but GCC still accepts.
We can test for these changes by using the following -Werror=
directives
-Werror=implicit-int
-Werror=implicit-function-declaration
-Werror=int-conversion
-Werror=strict-prototypes
-Werror=old-style-definition
Doing so revealed an issue with the auto/ tests in that the test
programs always define main as
int main()
rather than
int main(void)
which results in a bunch of errors like
build/autotest.c:3:23: error: function declaration isn't a prototype [-Werror=strict-prototypes]
3 | int main() {
| ^~~~
build/autotest.c: In function 'main':
build/autotest.c:3:23: error: old-style function definition [-Werror=old-style-definition]
The fix was easy, it only required fixing the main prototype with
find -type f -exec sed -i 's/int main() {/int main(void) {/g' {} \;
Regardless of these upcoming GCC changes, this is probably a good thing
to do anyway for correctness.
[0]: https://fedoraproject.org/wiki/Changes/PortingToModernC
Link: <https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/message/CJXKTLXJUPZ4F2C2VQOTNMEA5JAUPMBD/>
Link: <https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/message/6SGHPHPAXKCVJ6PUZ57WVDQ5TDBVIRMF/>
Reviewed-by: Alejandro Colomar <alx@nginx.com>
Signed-off-by: Andrew Clayton <a.clayton@nginx.com>
197 lines
4.4 KiB
Plaintext
197 lines
4.4 KiB
Plaintext
|
|
# Copyright (C) Igor Sysoev
|
|
# Copyright (C) NGINX, Inc.
|
|
|
|
|
|
# Linux epoll.
|
|
|
|
nxt_feature="Linux epoll"
|
|
nxt_feature_name=NXT_HAVE_EPOLL
|
|
nxt_feature_run=
|
|
nxt_feature_incs=
|
|
nxt_feature_libs=
|
|
nxt_feature_test="#include <sys/epoll.h>
|
|
#include <unistd.h>
|
|
|
|
int main(void) {
|
|
int n;
|
|
|
|
n = epoll_create(1);
|
|
close(n);
|
|
return 0;
|
|
}"
|
|
. auto/feature
|
|
|
|
if [ $nxt_found = yes ]; then
|
|
NXT_HAVE_EPOLL=YES
|
|
|
|
nxt_feature="Linux signalfd()"
|
|
nxt_feature_name=NXT_HAVE_SIGNALFD
|
|
nxt_feature_run=
|
|
nxt_feature_incs=
|
|
nxt_feature_libs=
|
|
nxt_feature_test="#include <signal.h>
|
|
#include <sys/signalfd.h>
|
|
#include <unistd.h>
|
|
|
|
int main(void) {
|
|
int n;
|
|
sigset_t mask;
|
|
|
|
sigemptyset(&mask);
|
|
n = signalfd(-1, &mask, 0);
|
|
close(n);
|
|
return 0;
|
|
}"
|
|
. auto/feature
|
|
|
|
|
|
nxt_feature="Linux eventfd()"
|
|
nxt_feature_name=NXT_HAVE_EVENTFD
|
|
nxt_feature_run=
|
|
nxt_feature_incs=
|
|
nxt_feature_libs=
|
|
nxt_feature_test="#include <sys/eventfd.h>
|
|
#include <unistd.h>
|
|
|
|
int main(void) {
|
|
int n;
|
|
|
|
n = eventfd(0, 0);
|
|
close(n);
|
|
return 0;
|
|
}"
|
|
. auto/feature
|
|
|
|
else
|
|
NXT_HAVE_EPOLL=NO
|
|
fi
|
|
|
|
|
|
# FreeBSD, MacOSX, NetBSD, OpenBSD kqueue.
|
|
|
|
nxt_feature="kqueue"
|
|
nxt_feature_name=NXT_HAVE_KQUEUE
|
|
nxt_feature_run=
|
|
nxt_feature_incs=
|
|
nxt_feature_libs=
|
|
nxt_feature_test="#include <sys/types.h>
|
|
#include <sys/event.h>
|
|
#include <unistd.h>
|
|
|
|
int main(void) {
|
|
int n;
|
|
|
|
n = kqueue();
|
|
close(n);
|
|
return 0;
|
|
}"
|
|
. auto/feature
|
|
|
|
if [ $nxt_found = yes ]; then
|
|
NXT_HAVE_KQUEUE=YES
|
|
|
|
nxt_feature="kqueue EVFILT_USER"
|
|
nxt_feature_name=NXT_HAVE_EVFILT_USER
|
|
nxt_feature_run=
|
|
nxt_feature_incs=
|
|
nxt_feature_libs=
|
|
nxt_feature_test="#include <stdlib.h>
|
|
#include <sys/types.h>
|
|
#include <sys/event.h>
|
|
|
|
int main(void) {
|
|
struct kevent kev;
|
|
|
|
kev.filter = EVFILT_USER;
|
|
kevent(0, &kev, 1, NULL, 0, NULL);
|
|
return 0;
|
|
}"
|
|
. auto/feature
|
|
|
|
else
|
|
NXT_HAVE_KQUEUE=NO
|
|
fi
|
|
|
|
|
|
# Solaris event port.
|
|
|
|
nxt_feature="Solaris event port"
|
|
nxt_feature_name=NXT_HAVE_EVENTPORT
|
|
nxt_feature_run=
|
|
nxt_feature_incs=
|
|
nxt_feature_libs=
|
|
nxt_feature_test="#include <port.h>
|
|
#include <unistd.h>
|
|
|
|
int main(void) {
|
|
int n;
|
|
|
|
n = port_create();
|
|
close(n);
|
|
return 0;
|
|
}"
|
|
. auto/feature
|
|
|
|
if [ $nxt_found = yes ]; then
|
|
NXT_HAVE_EVENTPORT=YES
|
|
else
|
|
NXT_HAVE_EVENTPORT=NO
|
|
fi
|
|
|
|
|
|
# Solaris, HP-UX, IRIX, Tru64 UNIX /dev/poll.
|
|
|
|
nxt_feature="/dev/poll"
|
|
nxt_feature_name=NXT_HAVE_DEVPOLL
|
|
nxt_feature_run=yes
|
|
nxt_feature_incs=
|
|
nxt_feature_libs=
|
|
nxt_feature_test="#include <fcntl.h>
|
|
#include <sys/ioctl.h>
|
|
#include <sys/devpoll.h>
|
|
#include <unistd.h>
|
|
|
|
int main(void) {
|
|
int n;
|
|
|
|
n = open(\"/dev/poll\", O_RDWR);
|
|
close(n);
|
|
return 0;
|
|
}"
|
|
. auto/feature
|
|
|
|
if [ $nxt_found = yes ]; then
|
|
NXT_HAVE_DEVPOLL=YES
|
|
else
|
|
NXT_HAVE_DEVPOLL=NO
|
|
fi
|
|
|
|
|
|
# AIX pollset.
|
|
|
|
nxt_feature="AIX pollset"
|
|
nxt_feature_name=NXT_HAVE_POLLSET
|
|
nxt_feature_run=yes
|
|
nxt_feature_incs=
|
|
nxt_feature_libs=
|
|
nxt_feature_test="#include <fcntl.h>
|
|
#include <sys/poll.h>
|
|
#include <sys/pollset.h>
|
|
#include <unistd.h>
|
|
|
|
int main(void) {
|
|
pollset_t n;
|
|
|
|
n = pollset_create(-1);
|
|
pollset_destroy(n);
|
|
return 0;
|
|
}"
|
|
. auto/feature
|
|
|
|
if [ $nxt_found = yes ]; then
|
|
NXT_HAVE_POLLSET=YES
|
|
else
|
|
NXT_HAVE_POLLSET=NO
|
|
fi
|