Future releases of GCC are planning to remove[0] default support for
some old features that were removed from C99 but GCC still accepts.
We can test for these changes by using the following -Werror=
directives
-Werror=implicit-int
-Werror=implicit-function-declaration
-Werror=int-conversion
-Werror=strict-prototypes
-Werror=old-style-definition
Doing so revealed an issue with the auto/ tests in that the test
programs always define main as
int main()
rather than
int main(void)
which results in a bunch of errors like
build/autotest.c:3:23: error: function declaration isn't a prototype [-Werror=strict-prototypes]
3 | int main() {
| ^~~~
build/autotest.c: In function 'main':
build/autotest.c:3:23: error: old-style function definition [-Werror=old-style-definition]
The fix was easy, it only required fixing the main prototype with
find -type f -exec sed -i 's/int main() {/int main(void) {/g' {} \;
Regardless of these upcoming GCC changes, this is probably a good thing
to do anyway for correctness.
[0]: https://fedoraproject.org/wiki/Changes/PortingToModernC
Link: <https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/message/CJXKTLXJUPZ4F2C2VQOTNMEA5JAUPMBD/>
Link: <https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/message/6SGHPHPAXKCVJ6PUZ57WVDQ5TDBVIRMF/>
Reviewed-by: Alejandro Colomar <alx@nginx.com>
Signed-off-by: Andrew Clayton <a.clayton@nginx.com>
225 lines
5.1 KiB
Plaintext
225 lines
5.1 KiB
Plaintext
|
|
# Copyright (C) Igor Sysoev
|
|
# Copyright (C) NGINX, Inc.
|
|
|
|
|
|
# Linux 2.6.32 CLOCK_REALTIME_COARSE.
|
|
# Linux clock_gettime() is in librt.
|
|
|
|
nxt_feature="Linux clock_gettime(CLOCK_REALTIME_COARSE)"
|
|
nxt_feature_name=NXT_HAVE_CLOCK_REALTIME_COARSE
|
|
nxt_feature_run=yes
|
|
nxt_feature_incs=
|
|
nxt_feature_libs="-lrt"
|
|
nxt_feature_test="#include <time.h>
|
|
|
|
int main(void) {
|
|
struct timespec ts;
|
|
|
|
if (clock_gettime(CLOCK_REALTIME_COARSE, &ts) == -1)
|
|
return 1;
|
|
return 0;
|
|
}"
|
|
. auto/feature
|
|
|
|
if [ $nxt_found = yes ]; then
|
|
NXT_LIBRT=$nxt_feature_libs
|
|
fi
|
|
|
|
|
|
# FreeBSD 7.0 CLOCK_REALTIME_FAST
|
|
|
|
nxt_feature="FreeBSD clock_gettime(CLOCK_REALTIME_FAST)"
|
|
nxt_feature_name=NXT_HAVE_CLOCK_REALTIME_FAST
|
|
nxt_feature_run=yes
|
|
nxt_feature_incs=
|
|
nxt_feature_libs=
|
|
nxt_feature_test="#include <time.h>
|
|
|
|
int main(void) {
|
|
struct timespec ts;
|
|
|
|
if (clock_gettime(CLOCK_REALTIME_FAST, &ts) == -1)
|
|
return 1;
|
|
return 0;
|
|
}"
|
|
. auto/feature
|
|
|
|
|
|
nxt_feature="clock_gettime(CLOCK_REALTIME)"
|
|
nxt_feature_name=NXT_HAVE_CLOCK_REALTIME
|
|
nxt_feature_run=yes
|
|
nxt_feature_incs=
|
|
nxt_feature_libs=
|
|
nxt_feature_test="#include <time.h>
|
|
|
|
int main(void) {
|
|
struct timespec ts;
|
|
|
|
if (clock_gettime(CLOCK_REALTIME, &ts) == -1)
|
|
return 1;
|
|
return 0;
|
|
}"
|
|
. auto/feature
|
|
|
|
|
|
if [ $nxt_found = no ]; then
|
|
|
|
# Linux and Solaris 10 clock_gettime() are in librt.
|
|
|
|
nxt_feature="clock_gettime(CLOCK_REALTIME) in librt"
|
|
nxt_feature_libs="-lrt"
|
|
. auto/feature
|
|
|
|
if [ $nxt_found = yes ]; then
|
|
NXT_LIBRT=$nxt_feature_libs
|
|
fi
|
|
fi
|
|
|
|
|
|
# Linux 2.6.32 CLOCK_MONOTONIC_COARSE.
|
|
# Linux clock_gettime() is in librt.
|
|
|
|
nxt_feature="Linux clock_gettime(CLOCK_MONOTONIC_COARSE)"
|
|
nxt_feature_name=NXT_HAVE_CLOCK_MONOTONIC_COARSE
|
|
nxt_feature_run=yes
|
|
nxt_feature_incs=
|
|
nxt_feature_libs="-lrt"
|
|
nxt_feature_test="#include <time.h>
|
|
|
|
int main(void) {
|
|
struct timespec ts;
|
|
|
|
if (clock_gettime(CLOCK_MONOTONIC_COARSE, &ts) == -1)
|
|
return 1;
|
|
return 0;
|
|
}"
|
|
. auto/feature
|
|
|
|
if [ $nxt_found = yes ]; then
|
|
NXT_LIBRT=$nxt_feature_libs
|
|
fi
|
|
|
|
|
|
# FreeBSD 7.0 CLOCK_MONOTONIC_FAST
|
|
|
|
nxt_feature="FreeBSD clock_gettime(CLOCK_MONOTONIC_FAST)"
|
|
nxt_feature_name=NXT_HAVE_CLOCK_MONOTONIC_FAST
|
|
nxt_feature_run=yes
|
|
nxt_feature_incs=
|
|
nxt_feature_libs=
|
|
nxt_feature_test="#include <time.h>
|
|
|
|
int main(void) {
|
|
struct timespec ts;
|
|
|
|
if (clock_gettime(CLOCK_MONOTONIC_FAST, &ts) == -1)
|
|
return 1;
|
|
return 0;
|
|
}"
|
|
. auto/feature
|
|
|
|
|
|
nxt_feature="clock_gettime(CLOCK_MONOTONIC)"
|
|
nxt_feature_name=NXT_HAVE_CLOCK_MONOTONIC
|
|
nxt_feature_run=yes
|
|
nxt_feature_incs=
|
|
nxt_feature_libs=
|
|
nxt_feature_test="#include <time.h>
|
|
|
|
int main(void) {
|
|
struct timespec ts;
|
|
|
|
if (clock_gettime(CLOCK_MONOTONIC, &ts) == -1)
|
|
return 1;
|
|
return 0;
|
|
}"
|
|
. auto/feature
|
|
|
|
|
|
if [ $nxt_found = no ]; then
|
|
|
|
# Linux and Solaris 10 clock_gettime() are in librt.
|
|
|
|
nxt_feature="clock_gettime(CLOCK_MONOTONIC) in librt"
|
|
nxt_feature_libs="-lrt"
|
|
. auto/feature
|
|
|
|
if [ $nxt_found = yes ]; then
|
|
NXT_LIBRT=$nxt_feature_libs
|
|
fi
|
|
fi
|
|
|
|
|
|
# HP-UX Mercury Library hg_gethrtime().
|
|
|
|
NXT_LIBHG=
|
|
|
|
nxt_feature="HP-UX hg_gethrtime()"
|
|
nxt_feature_name=NXT_HAVE_HG_GETHRTIME
|
|
nxt_feature_run=yes
|
|
nxt_feature_incs=
|
|
nxt_feature_libs="-lhg"
|
|
nxt_feature_test="#include <stdlib.h>
|
|
#include <sys/mercury.h>
|
|
|
|
int main(void) {
|
|
hg_gethrtime();
|
|
return 0;
|
|
}"
|
|
. auto/feature
|
|
|
|
if [ $nxt_found = yes ]; then
|
|
NXT_LIBHG=$nxt_feature_libs
|
|
fi
|
|
|
|
|
|
nxt_feature="struct tm.tm_gmtoff"
|
|
nxt_feature_name=NXT_HAVE_TM_GMTOFF
|
|
nxt_feature_run=
|
|
nxt_feature_incs=
|
|
nxt_feature_libs=
|
|
nxt_feature_test="#include <time.h>
|
|
|
|
int main(void) {
|
|
time_t t;
|
|
struct tm tm;
|
|
|
|
t = 0;
|
|
localtime_r(&t, &tm);
|
|
return tm.tm_gmtoff;
|
|
}"
|
|
. auto/feature
|
|
|
|
|
|
nxt_feature="altzone"
|
|
nxt_feature_name=NXT_HAVE_ALTZONE
|
|
nxt_feature_run=
|
|
nxt_feature_incs=
|
|
nxt_feature_libs=
|
|
nxt_feature_test="#include <time.h>
|
|
|
|
int main(void) {
|
|
altzone = 0;
|
|
return 0;
|
|
}"
|
|
. auto/feature
|
|
|
|
|
|
nxt_feature="localtime_r()"
|
|
nxt_feature_name=NXT_HAVE_LOCALTIME_R
|
|
nxt_feature_run=
|
|
nxt_feature_incs=
|
|
nxt_feature_libs=
|
|
nxt_feature_test="#include <time.h>
|
|
|
|
int main(void) {
|
|
time_t t;
|
|
struct tm tm;
|
|
|
|
t = 0;
|
|
localtime_r(&t, &tm);
|
|
return 0;
|
|
}"
|
|
. auto/feature
|