As reported by @andypost on GitHub, if you try to build Unit on a system
that uses musl libc (such as Alpine Linux) with clang then you get the
following
clang -c -pipe -fPIC -fvisibility=hidden -O -W -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -fstrict-aliasing -Wstrict-overflow=5 -Wmissing-prototypes -Werror -g -I src -I build/include \
\
\
-o build/src/nxt_socketpair.o \
-MMD -MF build/src/nxt_socketpair.dep -MT build/src/nxt_socketpair.o \
src/nxt_socketpair.c
In file included from src/nxt_socketpair.c:8:
src/nxt_socket_msg.h:138:17: error: comparison of integers of different signs: 'unsigned long' and 'long' [-Werror,-Wsign-compare]
cmsg = CMSG_NXTHDR(&msg, cmsg))
^~~~~~~~~~~~~~~~~~~~~~~
/usr/include/sys/socket.h:358:44: note: expanded from macro 'CMSG_NXTHDR'
__CMSG_LEN(cmsg) + sizeof(struct cmsghdr) >= __MHDR_END(mhdr) - (unsigned char *)(cmsg) \
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from src/nxt_socketpair.c:8:
src/nxt_socket_msg.h:177:17: error: comparison of integers of different signs: 'unsigned long' and 'long' [-Werror,-Wsign-compare]
cmsg = CMSG_NXTHDR(&msg, cmsg))
^~~~~~~~~~~~~~~~~~~~~~~
/usr/include/sys/socket.h:358:44: note: expanded from macro 'CMSG_NXTHDR'
__CMSG_LEN(cmsg) + sizeof(struct cmsghdr) >= __MHDR_END(mhdr) - (unsigned char *)(cmsg) \
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2 errors generated.
make: *** [build/Makefile:261: build/src/nxt_socketpair.o] Error 1
GCC works fine, it seems to have some smarts so that it doesn't give
warnings on system header files.
This seems to be a long standing issue with musl libc (bad casting in
the CMSG_NXTHDR macro) and the workaround employed by several projects
is to disable the -Wsign-compare clang warning for the code in question.
So, that's what we do. We wrap the CMSG_NXTHDR macro in a function, so
we can use the pre-processor in it to selectively disable the warning.
Link: <https://github.com/dotnet/runtime/issues/16438>
Link: <https://git.openembedded.org/meta-openembedded/tree/meta-oe/recipes-devtools/breakpad/breakpad/0001-Turn-off-sign-compare-for-musl-libc.patch>
Link: <https://github.com/dotnet/corefx/blob/57ff88bb75a0/src/Native/Unix/System.Native/pal_networking.c#L811-L829>
Link: <https://patchwork.yoctoproject.org/project/oe/patch/20220407191438.3696227-1-stefan@datenfreihafen.org/>
Closes: <https://github.com/nginx/unit/issues/936>
Signed-off-by: Andrew Clayton <a.clayton@nginx.com>
235 lines
5.7 KiB
C
235 lines
5.7 KiB
C
/*
|
|
* Copyright (C) NGINX, Inc.
|
|
*/
|
|
|
|
#ifndef _NXT_SOCKET_MSG_H_INCLUDED_
|
|
#define _NXT_SOCKET_MSG_H_INCLUDED_
|
|
|
|
#if (NXT_HAVE_UCRED)
|
|
#include <sys/un.h>
|
|
#endif
|
|
|
|
|
|
#if (NXT_HAVE_UCRED)
|
|
#define NXT_CRED_USECMSG 1
|
|
#define NXT_CRED_CMSGTYPE SCM_CREDENTIALS
|
|
#define NXT_CRED_GETPID(u) (u->pid)
|
|
|
|
typedef struct ucred nxt_socket_cred_t;
|
|
|
|
#elif (NXT_HAVE_MSGHDR_CMSGCRED)
|
|
#define NXT_CRED_USECMSG 1
|
|
#define NXT_CRED_CMSGTYPE SCM_CREDS
|
|
#define NXT_CRED_GETPID(u) (u->cmcred_pid)
|
|
|
|
typedef struct cmsgcred nxt_socket_cred_t;
|
|
#endif
|
|
|
|
#if (NXT_CRED_USECMSG)
|
|
#define NXT_OOB_RECV_SIZE \
|
|
(CMSG_SPACE(2 * sizeof(int)) + CMSG_SPACE(sizeof(nxt_socket_cred_t)))
|
|
#else
|
|
#define NXT_OOB_RECV_SIZE \
|
|
CMSG_SPACE(2 * sizeof(int))
|
|
#endif
|
|
|
|
#if (NXT_HAVE_MSGHDR_CMSGCRED)
|
|
#define NXT_OOB_SEND_SIZE \
|
|
(CMSG_SPACE(2 * sizeof(int)) + CMSG_SPACE(sizeof(nxt_socket_cred_t)))
|
|
#else
|
|
#define NXT_OOB_SEND_SIZE \
|
|
CMSG_SPACE(2 * sizeof(int))
|
|
#endif
|
|
|
|
|
|
typedef struct {
|
|
size_t size;
|
|
u_char buf[NXT_OOB_RECV_SIZE];
|
|
} nxt_recv_oob_t;
|
|
|
|
|
|
typedef struct {
|
|
size_t size;
|
|
u_char buf[NXT_OOB_SEND_SIZE];
|
|
} nxt_send_oob_t;
|
|
|
|
|
|
/**
|
|
* The nxt_sendmsg is a wrapper for sendmsg.
|
|
* The oob struct must be initialized using nxt_socket_msg_oob_init().
|
|
*/
|
|
NXT_EXPORT ssize_t nxt_sendmsg(nxt_socket_t s, nxt_iobuf_t *iob,
|
|
nxt_uint_t niob, const nxt_send_oob_t *oob);
|
|
|
|
/**
|
|
* The nxt_recvmsg is a wrapper for recvmsg.
|
|
* The oob buffer must be consumed by using nxt_socket_msg_oob_get().
|
|
*/
|
|
NXT_EXPORT ssize_t nxt_recvmsg(nxt_socket_t s,
|
|
nxt_iobuf_t *iob, nxt_uint_t niob, nxt_recv_oob_t *oob);
|
|
|
|
|
|
nxt_inline struct cmsghdr *
|
|
NXT_CMSG_NXTHDR(struct msghdr *msgh, struct cmsghdr *cmsg)
|
|
{
|
|
#if !defined(__GLIBC__) && defined(__clang__)
|
|
#pragma clang diagnostic push
|
|
#pragma clang diagnostic ignored "-Wsign-compare"
|
|
#endif
|
|
return CMSG_NXTHDR(msgh, cmsg);
|
|
#if !defined(__GLIBC__) && defined(__clang__)
|
|
#pragma clang diagnostic pop
|
|
#endif
|
|
}
|
|
|
|
|
|
nxt_inline void
|
|
nxt_socket_msg_oob_init(nxt_send_oob_t *oob, int *fds)
|
|
{
|
|
int nfds;
|
|
struct cmsghdr *cmsg;
|
|
|
|
#if (NXT_HAVE_MSGHDR_CMSGCRED)
|
|
cmsg = (struct cmsghdr *) (oob->buf);
|
|
/*
|
|
* Fill all padding fields with 0.
|
|
* Code in Go 1.11 validate cmsghdr using padding field as part of len.
|
|
* See Cmsghdr definition and socketControlMessageHeaderAndData function.
|
|
*/
|
|
nxt_memzero(cmsg, sizeof(struct cmsghdr));
|
|
|
|
cmsg->cmsg_len = CMSG_LEN(sizeof(nxt_socket_cred_t));
|
|
cmsg->cmsg_level = SOL_SOCKET;
|
|
cmsg->cmsg_type = NXT_CRED_CMSGTYPE;
|
|
|
|
oob->size = CMSG_SPACE(sizeof(nxt_socket_cred_t));
|
|
|
|
#else
|
|
oob->size = 0;
|
|
#endif
|
|
|
|
nfds = (fds[0] != -1 ? 1 : 0) + (fds[1] != -1 ? 1 : 0);
|
|
|
|
if (nfds == 0) {
|
|
return;
|
|
}
|
|
|
|
cmsg = (struct cmsghdr *) (oob->buf + oob->size);
|
|
|
|
nxt_memzero(cmsg, sizeof(struct cmsghdr));
|
|
|
|
cmsg->cmsg_len = CMSG_LEN(nfds * sizeof(int));
|
|
cmsg->cmsg_level = SOL_SOCKET;
|
|
cmsg->cmsg_type = SCM_RIGHTS;
|
|
|
|
/*
|
|
* nxt_memcpy() is used instead of simple
|
|
* *(int *) CMSG_DATA(&cmsg.cm) = fd;
|
|
* because GCC 4.4 with -O2/3/s optimization may issue a warning:
|
|
* dereferencing type-punned pointer will break strict-aliasing rules
|
|
*
|
|
* Fortunately, GCC with -O1 compiles this nxt_memcpy()
|
|
* in the same simple assignment as in the code above.
|
|
*/
|
|
nxt_memcpy(CMSG_DATA(cmsg), fds, nfds * sizeof(int));
|
|
|
|
oob->size += CMSG_SPACE(nfds * sizeof(int));
|
|
}
|
|
|
|
|
|
nxt_inline nxt_int_t
|
|
nxt_socket_msg_oob_get_fds(nxt_recv_oob_t *oob, nxt_fd_t *fd)
|
|
{
|
|
size_t size;
|
|
struct msghdr msg;
|
|
struct cmsghdr *cmsg;
|
|
|
|
msg.msg_control = oob->buf;
|
|
msg.msg_controllen = oob->size;
|
|
|
|
for (cmsg = CMSG_FIRSTHDR(&msg);
|
|
cmsg != NULL;
|
|
cmsg = NXT_CMSG_NXTHDR(&msg, cmsg))
|
|
{
|
|
size = cmsg->cmsg_len - CMSG_LEN(0);
|
|
|
|
if (cmsg->cmsg_level == SOL_SOCKET && cmsg->cmsg_type == SCM_RIGHTS) {
|
|
if (nxt_slow_path(size != sizeof(int) && size != 2 * sizeof(int))) {
|
|
return NXT_ERROR;
|
|
}
|
|
|
|
nxt_memcpy(fd, CMSG_DATA(cmsg), size);
|
|
|
|
return NXT_OK;
|
|
}
|
|
}
|
|
|
|
return NXT_OK;
|
|
}
|
|
|
|
|
|
nxt_inline nxt_int_t
|
|
nxt_socket_msg_oob_get(nxt_recv_oob_t *oob, nxt_fd_t *fd, nxt_pid_t *pid)
|
|
{
|
|
size_t size;
|
|
struct msghdr msg;
|
|
struct cmsghdr *cmsg;
|
|
|
|
if (oob->size == 0) {
|
|
return NXT_OK;
|
|
}
|
|
|
|
#if (NXT_CRED_USECMSG)
|
|
*pid = -1;
|
|
#endif
|
|
|
|
msg.msg_control = oob->buf;
|
|
msg.msg_controllen = oob->size;
|
|
|
|
for (cmsg = CMSG_FIRSTHDR(&msg);
|
|
cmsg != NULL;
|
|
cmsg = NXT_CMSG_NXTHDR(&msg, cmsg))
|
|
{
|
|
size = cmsg->cmsg_len - CMSG_LEN(0);
|
|
|
|
if (cmsg->cmsg_level == SOL_SOCKET && cmsg->cmsg_type == SCM_RIGHTS) {
|
|
if (nxt_slow_path(size != sizeof(int) && size != 2 * sizeof(int))) {
|
|
return NXT_ERROR;
|
|
}
|
|
|
|
nxt_memcpy(fd, CMSG_DATA(cmsg), size);
|
|
|
|
#if (!NXT_CRED_USECMSG)
|
|
break;
|
|
#endif
|
|
}
|
|
|
|
#if (NXT_CRED_USECMSG)
|
|
else if (cmsg->cmsg_level == SOL_SOCKET
|
|
&& cmsg->cmsg_type == NXT_CRED_CMSGTYPE)
|
|
{
|
|
nxt_socket_cred_t *creds;
|
|
|
|
if (nxt_slow_path(size != sizeof(nxt_socket_cred_t))) {
|
|
return NXT_ERROR;
|
|
}
|
|
|
|
creds = (nxt_socket_cred_t *) CMSG_DATA(cmsg);
|
|
*pid = NXT_CRED_GETPID(creds);
|
|
}
|
|
#endif
|
|
}
|
|
|
|
#if (NXT_CRED_USECMSG)
|
|
/* For platforms supporting credential passing, it's enforced */
|
|
if (nxt_slow_path(*pid == -1)) {
|
|
return NXT_ERROR;
|
|
}
|
|
#endif
|
|
|
|
return NXT_OK;
|
|
}
|
|
|
|
|
|
#endif /* _NXT_SOCKET_MSG_H_INCLUDED_ */
|