8f0dd9478e
Future releases of GCC are planning to remove[0] default support for
some old features that were removed from C99 but GCC still accepts.
We can test for these changes by using the following -Werror=
directives
-Werror=implicit-int
-Werror=implicit-function-declaration
-Werror=int-conversion
-Werror=strict-prototypes
-Werror=old-style-definition
Doing so revealed an issue with the auto/ tests in that the test
programs always define main as
int main()
rather than
int main(void)
which results in a bunch of errors like
build/autotest.c:3:23: error: function declaration isn't a prototype [-Werror=strict-prototypes]
3 | int main() {
| ^~~~
build/autotest.c: In function 'main':
build/autotest.c:3:23: error: old-style function definition [-Werror=old-style-definition]
The fix was easy, it only required fixing the main prototype with
find -type f -exec sed -i 's/int main() {/int main(void) {/g' {} \;
Regardless of these upcoming GCC changes, this is probably a good thing
to do anyway for correctness.
[0]: https://fedoraproject.org/wiki/Changes/PortingToModernC
Link: <https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/message/CJXKTLXJUPZ4F2C2VQOTNMEA5JAUPMBD/>
Link: <https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/message/6SGHPHPAXKCVJ6PUZ57WVDQ5TDBVIRMF/>
Reviewed-by: Alejandro Colomar <alx@nginx.com>
Signed-off-by: Andrew Clayton <a.clayton@nginx.com>
88 lines
2.3 KiB
Plaintext
88 lines
2.3 KiB
Plaintext
|
|
# Copyright (C) Igor Sysoev
|
|
# Copyright (C) NGINX, Inc.
|
|
|
|
|
|
# Linux, FreeBSD, Solaris, MacOSX.
|
|
|
|
nxt_feature="MAP_ANON"
|
|
nxt_feature_name=NXT_HAVE_MAP_ANON
|
|
nxt_feature_run=yes
|
|
nxt_feature_incs=
|
|
nxt_feature_libs=
|
|
nxt_feature_test="#include <stdlib.h>
|
|
#include <sys/mman.h>
|
|
|
|
int main(void) {
|
|
if (mmap(NULL, 4096, PROT_READ | PROT_WRITE,
|
|
MAP_PRIVATE | MAP_ANON, -1, 0)
|
|
== MAP_FAILED)
|
|
return 1;
|
|
return 0;
|
|
}"
|
|
. auto/feature
|
|
|
|
|
|
if [ $nxt_found = no ]; then
|
|
|
|
# Linux, Solaris, HP-UX.
|
|
|
|
nxt_feature="MAP_ANONYMOUS"
|
|
nxt_feature_name=NXT_HAVE_MAP_ANONYMOUS
|
|
nxt_feature_run=yes
|
|
nxt_feature_incs=
|
|
nxt_feature_libs=
|
|
nxt_feature_test="#include <stdlib.h>
|
|
#include <sys/mman.h>
|
|
|
|
int main(void) {
|
|
if (mmap(NULL, 4096, PROT_READ | PROT_WRITE,
|
|
MAP_PRIVATE | MAP_ANONYMOUS, -1, 0)
|
|
== MAP_FAILED)
|
|
return 1;
|
|
return 0;
|
|
}"
|
|
. auto/feature
|
|
fi
|
|
|
|
|
|
# Linux.
|
|
|
|
nxt_feature="MAP_POPULATE"
|
|
nxt_feature_name=NXT_HAVE_MAP_POPULATE
|
|
nxt_feature_run=no
|
|
nxt_feature_incs=
|
|
nxt_feature_libs=
|
|
nxt_feature_test="#include <stdlib.h>
|
|
#include <sys/mman.h>
|
|
|
|
int main(void) {
|
|
if (mmap(NULL, 4096, PROT_READ | PROT_WRITE,
|
|
MAP_SHARED | MAP_POPULATE, -1, 0)
|
|
== MAP_FAILED)
|
|
return 1;
|
|
return 0;
|
|
}"
|
|
. auto/feature
|
|
|
|
|
|
# FreeBSD.
|
|
|
|
nxt_feature="MAP_PREFAULT_READ"
|
|
nxt_feature_name=NXT_HAVE_MAP_PREFAULT_READ
|
|
nxt_feature_run=yes
|
|
nxt_feature_incs=
|
|
nxt_feature_libs=
|
|
nxt_feature_test="#include <stdlib.h>
|
|
#include <sys/mman.h>
|
|
|
|
int main(void) {
|
|
if (mmap(NULL, 4096, PROT_READ | PROT_WRITE,
|
|
MAP_PRIVATE | MAP_ANON | MAP_PREFAULT_READ,
|
|
-1, 0)
|
|
== MAP_FAILED)
|
|
return 1;
|
|
return 0;
|
|
}"
|
|
. auto/feature
|