952bcc50bf
We had a mix of styles for declaring function-like macros:
Style A:
#define \
foo() \
do { \
... \
} while (0)
Style B:
#define foo() \
do { \
... \
} while (0)
We had a similar number of occurences of each style:
$ grep -rnI '^\w*(.*\\' | wc -l
244
$ grep -rn 'define.*(.*)' | wc -l
239
(Those regexes aren't perfect, but a very decent approximation.)
Real examples:
$ find src -type f | xargs sed -n '/^nxt_double_is_zero/,/^$/p'
nxt_double_is_zero(f) \
(fabs(f) <= FLT_EPSILON)
$ find src -type f | xargs sed -n '/define nxt_http_field_set/,/^$/p'
#define nxt_http_field_set(_field, _name, _value) \
do { \
(_field)->name_length = nxt_length(_name); \
(_field)->value_length = nxt_length(_value); \
(_field)->name = (u_char *) _name; \
(_field)->value = (u_char *) _value; \
} while (0)
I'd like to standardize on a single style for them, and IMO,
having the identifier in the same line as #define is a better
option for the following reasons:
- Programmers are used to `#define foo() ...` (readability).
- One less line of code.
- The program for finding them is really simple (see below).
function grep_ngx_func()
{
if (($# != 1)); then
>&2 echo "Usage: ${FUNCNAME[0]} <func>";
return 1;
fi;
find src -type f \
| grep '\.[ch]$' \
| xargs grep -l "$1" \
| sort \
| xargs pcregrep -Mn "(?s)^\$[\w\s*]+?^$1\(.*?^}";
find src -type f \
| grep '\.[ch]$' \
| xargs grep -l "$1" \
| sort \
| xargs pcregrep -Mn "(?s)define $1\(.*?^$" \
| sed -E '1s/^[^:]+:[0-9]+:/&\n\n/';
}
$ grep_ngx_func
Usage: grep_ngx_func <func>
$ grep_ngx_func nxt_http_field_set
src/nxt_http.h:98:
#define nxt_http_field_set(_field, _name, _value) \
do { \
(_field)->name_length = nxt_length(_name); \
(_field)->value_length = nxt_length(_value); \
(_field)->name = (u_char *) _name; \
(_field)->value = (u_char *) _value; \
} while (0)
$ grep_ngx_func nxt_sprintf
src/nxt_sprintf.c:56:
u_char * nxt_cdecl
nxt_sprintf(u_char *buf, u_char *end, const char *fmt, ...)
{
u_char *p;
va_list args;
va_start(args, fmt);
p = nxt_vsprintf(buf, end, fmt, args);
va_end(args);
return p;
}
................
Scripted change:
................
$ find src -type f \
| grep '\.[ch]$' \
| xargs sed -i '/define *\\$/{N;s/ *\\\n/ /;s/ //}'
50 lines
1.7 KiB
C
50 lines
1.7 KiB
C
|
|
/*
|
|
* Copyright (C) Igor Sysoev
|
|
* Copyright (C) NGINX, Inc.
|
|
*/
|
|
|
|
#ifndef _NXT_LOG_MODERATION_H_INCLUDED_
|
|
#define _NXT_LOG_MODERATION_H_INCLUDED_
|
|
|
|
|
|
typedef struct {
|
|
uint32_t level;
|
|
uint32_t limit;
|
|
const char *msg;
|
|
nxt_thread_spinlock_t lock;
|
|
nxt_pid_t pid;
|
|
nxt_uint_t count;
|
|
nxt_time_t last;
|
|
nxt_timer_t timer;
|
|
} nxt_log_moderation_t;
|
|
|
|
|
|
#define NXT_LOG_MODERATION 0, -1, 0, 0, NXT_TIMER
|
|
|
|
|
|
#define nxt_log_alert_moderate(_mod, _log, ...) \
|
|
do { \
|
|
nxt_log_t *_log_ = _log; \
|
|
\
|
|
if (nxt_log_moderate_allow(_mod)) { \
|
|
_log_->handler(NXT_LOG_ALERT, _log_, __VA_ARGS__); \
|
|
} \
|
|
} while (0)
|
|
|
|
|
|
#define nxt_log_moderate(_mod, _level, _log, ...) \
|
|
do { \
|
|
nxt_log_t *_log_ = _log; \
|
|
\
|
|
if (_log_->level >= (_level) && nxt_log_moderate_allow(_mod)) { \
|
|
_log_->handler(_level, _log_, __VA_ARGS__); \
|
|
} \
|
|
} while (0)
|
|
|
|
|
|
nxt_bool_t nxt_log_moderate_allow(nxt_log_moderation_t *mod);
|
|
|
|
|
|
#endif /* _NXT_LOG_MODERATION_H_INCLUDED_ */
|